[Qemu-devel] [PATCH for-2.4] s390x: the stragglers

[Qemu-devel] [PATCH for-2.4] s390x: the stragglers

[Cornelia Huck]

I've added two more patches to my s390-next branch at

git://github.com/cohuck/qemu s390-next

- Christian's fix for the ipl device id
  (<1434642868-18685-1-git-send-email-borntraeger@de.ibm.com>)
- a gdb fix from David

Will send a pull request later this week.

David Hildenbrand (1):
  s390x/gdb: synchronize cpu state after modifying acrs

 target-s390x/gdbstub.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.4.5

[Qemu-devel] [PATCH for-2.4] s390x/gdb: synchronize cpu state after modifying acrs

[Cornelia Huck]

From: David Hildenbrand <dahi@linux.vnet.ibm.com>

Whenever we touch the access control registers, we have to make sure that
the values will make it into kvm. Otherwise the change will simply be lost.

When synchronizing qemu and kvm, a normal KVM_PUT_RUNTIME_STATE does not take
care of these registers. Let's simply trigger a KVM_PUT_FULL_STATE sync,
so the values will directly be written to kvm. The performance overhead can
be ignored and this is much cleaner than manually writing these registers to kvm
via our two supported ways.

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 target-s390x/gdbstub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target-s390x/gdbstub.c b/target-s390x/gdbstub.c
index ddc14a6..31f2049 100644
--- a/target-s390x/gdbstub.c
+++ b/target-s390x/gdbstub.c
@@ -92,6 +92,7 @@ static int cpu_write_ac_reg(CPUS390XState *env, uint8_t *mem_buf, int n)
     switch (n) {
     case S390_A0_REGNUM ... S390_A15_REGNUM:
         env->aregs[n] = ldl_p(mem_buf);
+        cpu_synchronize_post_init(ENV_GET_CPU(env));
         return 4;
     default:
         return 0;
-- 
2.4.5