[Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

[Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

[Gerd Hoffmann]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/qemu/option.h   | 2 +-
 include/qemu/typedefs.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/qemu/option.h b/include/qemu/option.h
index 57e51c9..28195ba 100644
--- a/include/qemu/option.h
+++ b/include/qemu/option.h
@@ -28,6 +28,7 @@
 
 #include <stdint.h>
 #include "qemu/queue.h"
+#include "qemu/typedefs.h"
 #include "qapi/error.h"
 #include "qapi/qmp/qdict.h"
 
@@ -45,7 +46,6 @@ bool has_help_option(const char *param);
 bool is_valid_option_list(const char *param);
 
 typedef struct QemuOpt QemuOpt;
-typedef struct QemuOpts QemuOpts;
 typedef struct QemuOptsList QemuOptsList;
 
 enum QemuOptType {
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index 6fdcbcd..690ff69 100644
--- a/include/qemu/typedefs.h
+++ b/include/qemu/typedefs.h
@@ -66,6 +66,7 @@ typedef struct QEMUBH QEMUBH;
 typedef struct QemuConsole QemuConsole;
 typedef struct QEMUFile QEMUFile;
 typedef struct QEMUMachine QEMUMachine;
+typedef struct QemuOpts QemuOpts;
 typedef struct QEMUSGList QEMUSGList;
 typedef struct QEMUSizedBuffer QEMUSizedBuffer;
 typedef struct QEMUTimerListGroup QEMUTimerListGroup;
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

[Peter Maydell]

On 30 June 2015 at 10:09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  include/qemu/option.h   | 2 +-
>  include/qemu/typedefs.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

I don't object necessarily, but it would be nice if the
commit message said what the rationale for the change was...

thanks
-- PMM

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

[Gerd Hoffmann]

On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote:
> On 30 June 2015 at 10:09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  include/qemu/option.h   | 2 +-
> >  include/qemu/typedefs.h | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> I don't object necessarily, but it would be nice if the
> commit message said what the rationale for the change was...

Build failure, with not-yet submitted patches,
due to QemuOpts being undeclared.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

[Markus Armbruster]

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote:
>> On 30 June 2015 at 10:09, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> > ---
>> >  include/qemu/option.h   | 2 +-
>> >  include/qemu/typedefs.h | 1 +
>> >  2 files changed, 2 insertions(+), 1 deletion(-)
>> 
>> I don't object necessarily, but it would be nice if the
>> commit message said what the rationale for the change was...
>
> Build failure, with not-yet submitted patches,
> due to QemuOpts being undeclared.

Recommend to post it right before a patch that breaks without it,
because that makes explaining why easier.