From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h
Date: Tue, 30 Jun 2015 13:18:15 +0200 [thread overview]
Message-ID: <1435663095.30958.54.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA8iq5Q84NH59zjS67O93Vq7a1u=9iyoVXB-GeuxA4BVag@mail.gmail.com>
On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote:
> On 30 June 2015 at 10:09, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > include/qemu/option.h | 2 +-
> > include/qemu/typedefs.h | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
>
> I don't object necessarily, but it would be nice if the
> commit message said what the rationale for the change was...
Build failure, with not-yet submitted patches,
due to QemuOpts being undeclared.
cheers,
Gerd
next prev parent reply other threads:[~2015-06-30 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 9:09 [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h Gerd Hoffmann
2015-06-30 9:15 ` Peter Maydell
2015-06-30 11:18 ` Gerd Hoffmann [this message]
2015-07-01 16:09 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435663095.30958.54.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).