From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9tYV-0004s0-96 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 07:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9tYS-0001EI-0M for qemu-devel@nongnu.org; Tue, 30 Jun 2015 07:18:23 -0400 Message-ID: <1435663095.30958.54.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 30 Jun 2015 13:18:15 +0200 In-Reply-To: References: <1435655374-20741-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote: > On 30 June 2015 at 10:09, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > include/qemu/option.h | 2 +- > > include/qemu/typedefs.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > I don't object necessarily, but it would be nice if the > commit message said what the rationale for the change was... Build failure, with not-yet submitted patches, due to QemuOpts being undeclared. cheers, Gerd