qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	pbonzini@redhat.com, qemu-block@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH RFC 0/4] aio: Use epoll_wait in aio_poll
Date: Tue, 30 Jun 2015 21:19:41 +0800	[thread overview]
Message-ID: <1435670385-625-1-git-send-email-famz@redhat.com> (raw)

epoll is more scalable than ppoll. It performs faster than ppoll when the
number of polled fds is high.

See patch 4 for an example of the senario and some benchmark data.

Note: it is only effective on iothread (dataplane), while the main loop cannot
benefit from this yet, because the iohandler and chardev GSource's don't easily
fit into this epoll interface style (that's why main loop uses qemu_poll_ns
directly instead of aio_poll()).

There is hardly any timer activity in iothreads for now, as a result the
timeout is always 0 or -1. Therefore, timerfd, or the said nanosecond
epoll_pwait1 interface, which fixes the timeout granularity deficiency is not
immediately necessary at this point, but still that will be simple to add.

Please review!

Fam

Fam Zheng (4):
  aio: Introduce aio_set_fd_handler_pri
  aio: Move aio_set_fd_handler to async.c
  aio: Introduce aio_context_setup
  aio-posix: Use epoll in aio_poll

 aio-posix.c         | 127 +++++++++++++++++++++++++++++++++++++++++++++++-----
 aio-win32.c         |   7 +--
 async.c             |  24 ++++++++--
 include/block/aio.h |   6 +++
 4 files changed, 144 insertions(+), 20 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-06-30 13:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 13:19 Fam Zheng [this message]
2015-06-30 13:19 ` [Qemu-devel] [PATCH RFC 1/4] aio: Introduce aio_set_fd_handler_pri Fam Zheng
2015-07-07 14:29   ` Stefan Hajnoczi
2015-07-08  1:07     ` Fam Zheng
2015-06-30 13:19 ` [Qemu-devel] [PATCH RFC 2/4] aio: Move aio_set_fd_handler to async.c Fam Zheng
2015-07-07 14:30   ` Stefan Hajnoczi
2015-06-30 13:19 ` [Qemu-devel] [PATCH RFC 3/4] aio: Introduce aio_context_setup Fam Zheng
2015-07-07 14:35   ` Stefan Hajnoczi
2015-07-08  1:15     ` Fam Zheng
2015-07-08 10:51       ` Stefan Hajnoczi
2015-06-30 13:19 ` [Qemu-devel] [PATCH RFC 4/4] aio-posix: Use epoll in aio_poll Fam Zheng
2015-07-07 15:08   ` Stefan Hajnoczi
2015-07-07 15:27     ` Paolo Bonzini
2015-07-08  1:01     ` Fam Zheng
2015-07-08 10:58       ` Stefan Hajnoczi
2015-07-10  0:46         ` Fam Zheng
2015-07-13 10:02           ` Stefan Hajnoczi
2015-07-07 14:54 ` [Qemu-devel] [PATCH RFC 0/4] aio: Use epoll_wait " Christian Borntraeger
2015-07-08  1:02   ` Fam Zheng
2015-07-08  7:59     ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435670385-625-1-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).