qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, John Snow <jsnow@redhat.com>,
	armbru@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC 00/10] fix 2.88mb floppy diskette support
Date: Tue, 30 Jun 2015 21:20:30 -0400	[thread overview]
Message-ID: <1435713640-12362-1-git-send-email-jsnow@redhat.com> (raw)

Yep, it's been broken for 10 years too.
No, it's not a CVE.

The problem is that QEMU doesn't have a configuration option
for the type of floppy drive you want. It determines it based
on the diskette you insert at boot.

If you don't insert one, it always chooses a 1.44MB type.

I want to change the default to a 2.88MB type and users to switch
back and forth between 2.88 and 1.44MB diskettes.

Shuffle things around a bit to make this magic happen.

This is just an RFC, for many reasons, mostly the 2.4 timeframe,
my unfamiliarity with the qdev property system, uncertainty over
where/how I added this properties, uncertainty over whether or not
READ_ID is really expected to work without a floppy disk or not
(which impacts if fdc-test is broken or not!) and other sloppy
design issues.

John Snow (10):
  fdc: Make default FDrive type explicit
  fdc: add default drive type option
  fdc: respect default drive type
  fdc: move pick_geometry
  fdc: refactor pick_geometry
  fdc: add physical disk sizes
  fdc: add disk field
  fdc: refactor pick_geometry
  qtest/fdc: Support for 2.88MB drives
  fdc: change default drive to 288

 hw/block/fdc.c               | 189 ++++++++++++++++++++++++++++++-------------
 hw/core/qdev-properties.c    |  12 +++
 include/hw/block/fdc.h       |   7 +-
 include/hw/qdev-properties.h |   1 +
 qapi/block.json              |  15 ++++
 tests/fdc-test.c             |   2 +-
 6 files changed, 161 insertions(+), 65 deletions(-)

-- 
2.1.0

             reply	other threads:[~2015-07-01  1:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  1:20 John Snow [this message]
2015-07-01  1:20 ` [Qemu-devel] [RFC 01/10] fdc: Make default FDrive type explicit John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 02/10] fdc: add default drive type option John Snow
2015-07-03 13:18   ` Markus Armbruster
2015-07-04  5:34     ` John Snow
2015-07-04  6:48       ` Markus Armbruster
2015-07-03 13:21   ` Markus Armbruster
2015-07-01  1:20 ` [Qemu-devel] [RFC 03/10] fdc: respect default drive type John Snow
2015-07-03 13:34   ` Markus Armbruster
2015-07-04  5:49     ` John Snow
2015-07-04  6:47       ` Markus Armbruster
2015-07-06 15:52         ` John Snow
2015-07-22 15:00           ` Markus Armbruster
2015-07-01  1:20 ` [Qemu-devel] [RFC 04/10] fdc: move pick_geometry John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:36   ` Markus Armbruster
2015-07-01  1:20 ` [Qemu-devel] [RFC 06/10] fdc: add physical disk sizes John Snow
2015-07-03 13:38   ` Markus Armbruster
2015-07-04  5:39     ` John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 07/10] fdc: add disk field John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:45   ` Markus Armbruster
2015-07-04  5:40     ` John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 09/10] qtest/fdc: Support for 2.88MB drives John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 10/10] fdc: change default drive to 288 John Snow
2015-07-05 14:53   ` Kevin O'Connor
2015-07-06 12:41     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435713640-12362-1-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).