From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZA6hs-0001TO-A4 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 21:20:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZA6hq-000886-On for qemu-devel@nongnu.org; Tue, 30 Jun 2015 21:20:56 -0400 From: John Snow Date: Tue, 30 Jun 2015 21:20:30 -0400 Message-Id: <1435713640-12362-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [RFC 00/10] fix 2.88mb floppy diskette support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, John Snow , armbru@redhat.com, qemu-devel@nongnu.org Yep, it's been broken for 10 years too. No, it's not a CVE. The problem is that QEMU doesn't have a configuration option for the type of floppy drive you want. It determines it based on the diskette you insert at boot. If you don't insert one, it always chooses a 1.44MB type. I want to change the default to a 2.88MB type and users to switch back and forth between 2.88 and 1.44MB diskettes. Shuffle things around a bit to make this magic happen. This is just an RFC, for many reasons, mostly the 2.4 timeframe, my unfamiliarity with the qdev property system, uncertainty over where/how I added this properties, uncertainty over whether or not READ_ID is really expected to work without a floppy disk or not (which impacts if fdc-test is broken or not!) and other sloppy design issues. John Snow (10): fdc: Make default FDrive type explicit fdc: add default drive type option fdc: respect default drive type fdc: move pick_geometry fdc: refactor pick_geometry fdc: add physical disk sizes fdc: add disk field fdc: refactor pick_geometry qtest/fdc: Support for 2.88MB drives fdc: change default drive to 288 hw/block/fdc.c | 189 ++++++++++++++++++++++++++++++------------- hw/core/qdev-properties.c | 12 +++ include/hw/block/fdc.h | 7 +- include/hw/qdev-properties.h | 1 + qapi/block.json | 15 ++++ tests/fdc-test.c | 2 +- 6 files changed, 161 insertions(+), 65 deletions(-) -- 2.1.0