qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, John Snow <jsnow@redhat.com>,
	armbru@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC 06/10] fdc: add physical disk sizes
Date: Tue, 30 Jun 2015 21:20:36 -0400	[thread overview]
Message-ID: <1435713640-12362-7-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1435713640-12362-1-git-send-email-jsnow@redhat.com>

2.88MB capable drives can accept 1.44MB floppies,
for instance. To rework the pick_geometry function,
we need to know if our current drive can even accept
the type of disks we're considering.

NB: This allows us to distinguish between all of the
"total sectors" collisions between 1.20MB and 1.44MB
diskette types.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/block/fdc.c | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 4004b98..6e5f87b 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -59,6 +59,11 @@ typedef enum FDriveRate {
     FDRIVE_RATE_1M   = 0x03,  /*   1 Mbps */
 } FDriveRate;
 
+typedef enum FDriveSize {
+    FDRIVE_SIZE_350,
+    FDRIVE_SIZE_525
+} FDriveSize;
+
 typedef struct FDFormat {
     FDriveType drive;
     uint8_t last_sect;
@@ -95,15 +100,15 @@ static const FDFormat fd_formats[] = {
     { FDRIVE_DRV_144, 14, 80, 1, FDRIVE_RATE_250K, },
     /* 1.2 MB 5"1/4 floppy disks */
     { FDRIVE_DRV_120, 15, 80, 1, FDRIVE_RATE_500K, },
-    { FDRIVE_DRV_120, 18, 80, 1, FDRIVE_RATE_500K, },
+    { FDRIVE_DRV_120, 18, 80, 1, FDRIVE_RATE_500K, }, /* conflicts w/ #0 */
     { FDRIVE_DRV_120, 18, 82, 1, FDRIVE_RATE_500K, },
     { FDRIVE_DRV_120, 18, 83, 1, FDRIVE_RATE_500K, },
-    { FDRIVE_DRV_120, 20, 80, 1, FDRIVE_RATE_500K, },
+    { FDRIVE_DRV_120, 20, 80, 1, FDRIVE_RATE_500K, }, /* conflicts w/ #1 */
     /* 720 kB 5"1/4 floppy disks */
-    { FDRIVE_DRV_120,  9, 80, 1, FDRIVE_RATE_250K, },
+    { FDRIVE_DRV_120,  9, 80, 1, FDRIVE_RATE_250K, }, /* conflicts w/ #13 */
     { FDRIVE_DRV_120, 11, 80, 1, FDRIVE_RATE_250K, },
     /* 360 kB 5"1/4 floppy disks */
-    { FDRIVE_DRV_120,  9, 40, 1, FDRIVE_RATE_300K, },
+    { FDRIVE_DRV_120,  9, 40, 1, FDRIVE_RATE_300K, }, /* conflicts w/ #32 */
     { FDRIVE_DRV_120,  9, 40, 0, FDRIVE_RATE_300K, },
     { FDRIVE_DRV_120, 10, 41, 1, FDRIVE_RATE_300K, },
     { FDRIVE_DRV_120, 10, 42, 1, FDRIVE_RATE_300K, },
@@ -116,6 +121,20 @@ static const FDFormat fd_formats[] = {
     { FDRIVE_DRV_NONE, -1, -1, 0, 0, },
 };
 
+__attribute__((__unused__))
+static FDriveSize drive_size(FDriveType drive)
+{
+    switch (drive) {
+    case FDRIVE_DRV_120:
+        return FDRIVE_SIZE_525;
+    case FDRIVE_DRV_144:
+    case FDRIVE_DRV_288:
+        return FDRIVE_SIZE_350;
+    default:
+        return -1;
+    }
+}
+
 #define GET_CUR_DRV(fdctrl) ((fdctrl)->cur_drv)
 #define SET_CUR_DRV(fdctrl, drive) ((fdctrl)->cur_drv = (drive))
 
-- 
2.1.0

  parent reply	other threads:[~2015-07-01  1:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  1:20 [Qemu-devel] [RFC 00/10] fix 2.88mb floppy diskette support John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 01/10] fdc: Make default FDrive type explicit John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 02/10] fdc: add default drive type option John Snow
2015-07-03 13:18   ` Markus Armbruster
2015-07-04  5:34     ` John Snow
2015-07-04  6:48       ` Markus Armbruster
2015-07-03 13:21   ` Markus Armbruster
2015-07-01  1:20 ` [Qemu-devel] [RFC 03/10] fdc: respect default drive type John Snow
2015-07-03 13:34   ` Markus Armbruster
2015-07-04  5:49     ` John Snow
2015-07-04  6:47       ` Markus Armbruster
2015-07-06 15:52         ` John Snow
2015-07-22 15:00           ` Markus Armbruster
2015-07-01  1:20 ` [Qemu-devel] [RFC 04/10] fdc: move pick_geometry John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:36   ` Markus Armbruster
2015-07-01  1:20 ` John Snow [this message]
2015-07-03 13:38   ` [Qemu-devel] [RFC 06/10] fdc: add physical disk sizes Markus Armbruster
2015-07-04  5:39     ` John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 07/10] fdc: add disk field John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:45   ` Markus Armbruster
2015-07-04  5:40     ` John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 09/10] qtest/fdc: Support for 2.88MB drives John Snow
2015-07-01  1:20 ` [Qemu-devel] [RFC 10/10] fdc: change default drive to 288 John Snow
2015-07-05 14:53   ` Kevin O'Connor
2015-07-06 12:41     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435713640-12362-7-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).