From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZACQT-0001QD-I3 for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZACQN-0008Id-P6 for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:27:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZACQN-0008IZ-JB for qemu-devel@nongnu.org; Wed, 01 Jul 2015 03:27:15 -0400 Message-ID: <1435735632.4160.21.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 01 Jul 2015 09:27:12 +0200 In-Reply-To: <20150630143628.GA8021@morn.localdomain> References: <1435653553-7728-1-git-send-email-kraxel@redhat.com> <1435653553-7728-3-git-send-email-kraxel@redhat.com> <20150630143628.GA8021@morn.localdomain> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" On Di, 2015-06-30 at 10:36 -0400, Kevin O'Connor wrote: > On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote: > > virtio version 1.0 registers can (and actually do in the qemu > > implementation) live in mmio space. So we must run the blk and > > scsi virtio drivers in 32bit mode, otherwise we can't access them. > > > > This also allows to drop a bunch of GET_LOWFLAT calls from the virtio > > code in the following patches. > > I think this patch is missing a "if (!MODESEGMENT)" check in > src/hw/blockcmd.c - otherwise the virtio scsi code will still be > included in the 16bit section. > > Also, this patch (or a follow up patch) should update the Makefile to > not compile the virtio code in 16bit mode. Both fixed. cheers, Gerd