From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAFIV-0006x1-Ug for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:31:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAFIT-0004Dd-8U for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:31:19 -0400 Received: from mail-pa0-x22d.google.com ([2607:f8b0:400e:c03::22d]:36486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAFIT-0004DU-1p for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:31:17 -0400 Received: by paceq1 with SMTP id eq1so21165063pac.3 for ; Wed, 01 Jul 2015 03:31:16 -0700 (PDT) From: sfeldma@gmail.com Date: Wed, 1 Jul 2015 03:33:08 -0700 Message-Id: <1435746792-41278-2-git-send-email-sfeldma@gmail.com> In-Reply-To: <1435746792-41278-1-git-send-email-sfeldma@gmail.com> References: <1435746792-41278-1-git-send-email-sfeldma@gmail.com> Subject: [Qemu-devel] [PATCH 1/5] rocker: fix misplaced break statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jiri@resnulli.us, stefanha@redhat.com From: Scott Feldman Premature break in switch case block. This particular case (group L2 rewrite) will be used for L2 LAG and L3 ECMP support, neither of which are enabled in the guest driver at this time, but are under development. Signed-off-by: Scott Feldman Reported-by: Paolo Bonzini --- hw/net/rocker/rocker_of_dpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c index b25a17d..02b3896 100644 --- a/hw/net/rocker/rocker_of_dpa.c +++ b/hw/net/rocker/rocker_of_dpa.c @@ -2525,7 +2525,6 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data) ngroup->has_set_vlan_id = true; ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id); } - break; if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) { ngroup->has_set_eth_src = true; ngroup->set_eth_src = @@ -2536,6 +2535,7 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data) ngroup->set_eth_dst = qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a); } + break; case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD: case ROCKER_OF_DPA_GROUP_TYPE_L2_MCAST: ngroup->has_vlan_id = true; -- 1.7.10.4