* [Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT
@ 2015-07-01 13:59 Aurelien Jarno
2015-07-08 12:27 ` Leon Alrae
0 siblings, 1 reply; 2+ messages in thread
From: Aurelien Jarno @ 2015-07-01 13:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Leon Alrae, Dr. David Alan Gilbert, Aurelien Jarno
When syncing the task ASID with EntryHi, correctly or the value instead
of assigning it.
Reported-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Cc: Leon Alrae <leon.alrae@imgtec.com>
---
target-mips/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 2a9ddff..d457a29 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -661,7 +661,7 @@ static void sync_c0_tcstatus(CPUMIPSState *cpu, int tc,
/* Sync the TASID with EntryHi. */
cpu->CP0_EntryHi &= ~0xff;
- cpu->CP0_EntryHi = tasid;
+ cpu->CP0_EntryHi |= tasid;
compute_hflags(cpu);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT
2015-07-01 13:59 [Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT Aurelien Jarno
@ 2015-07-08 12:27 ` Leon Alrae
0 siblings, 0 replies; 2+ messages in thread
From: Leon Alrae @ 2015-07-08 12:27 UTC (permalink / raw)
To: Aurelien Jarno, qemu-devel; +Cc: Dr. David Alan Gilbert
On 01/07/2015 14:59, Aurelien Jarno wrote:
> When syncing the task ASID with EntryHi, correctly or the value instead
> of assigning it.
>
> Reported-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> ---
> target-mips/op_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
Thanks,
Leon
(FYI, I just returned from holidays and I'm starting preparing a pull request
targeting -rc1 as probably is a bit too late for -rc0...)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-08 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 13:59 [Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT Aurelien Jarno
2015-07-08 12:27 ` Leon Alrae
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).