From: Gerd Hoffmann <kraxel@redhat.com>
To: seabios@seabios.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v3 16/25] virtio: add version 1.0 support to vp_find_vq
Date: Wed, 1 Jul 2015 16:41:01 +0200 [thread overview]
Message-ID: <1435761670-19520-17-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1435761670-19520-1-git-send-email-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
src/hw/virtio-pci.c | 58 +++++++++++++++++++++++++++++++++++++++--------------
1 file changed, 43 insertions(+), 15 deletions(-)
diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c
index 240cd2f..dcbf6d7 100644
--- a/src/hw/virtio-pci.c
+++ b/src/hw/virtio-pci.c
@@ -118,7 +118,6 @@ void vp_notify(struct vp_device *vp, struct vring_virtqueue *vq)
int vp_find_vq(struct vp_device *vp, int queue_index,
struct vring_virtqueue **p_vq)
{
- int ioaddr = GET_LOWFLAT(vp->ioaddr);
u16 num;
ASSERT32FLAT();
@@ -129,34 +128,49 @@ int vp_find_vq(struct vp_device *vp, int queue_index,
}
memset(vq, 0, sizeof(*vq));
+
/* select the queue */
-
- outw(queue_index, ioaddr + VIRTIO_PCI_QUEUE_SEL);
+ if (vp->use_modern) {
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_select, queue_index);
+ } else {
+ vp_write(&vp->legacy, virtio_pci_legacy, queue_sel, queue_index);
+ }
/* check if the queue is available */
-
- num = inw(ioaddr + VIRTIO_PCI_QUEUE_NUM);
+ if (vp->use_modern) {
+ num = vp_read(&vp->common, virtio_pci_common_cfg, queue_size);
+ if (num > MAX_QUEUE_NUM) {
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_size,
+ MAX_QUEUE_NUM);
+ num = vp_read(&vp->common, virtio_pci_common_cfg, queue_size);
+ }
+ } else {
+ num = vp_read(&vp->legacy, virtio_pci_legacy, queue_num);
+ }
if (!num) {
dprintf(1, "ERROR: queue size is 0\n");
goto fail;
}
-
if (num > MAX_QUEUE_NUM) {
dprintf(1, "ERROR: queue size %d > %d\n", num, MAX_QUEUE_NUM);
goto fail;
}
/* check if the queue is already active */
-
- if (inl(ioaddr + VIRTIO_PCI_QUEUE_PFN)) {
- dprintf(1, "ERROR: queue already active\n");
- goto fail;
+ if (vp->use_modern) {
+ if (vp_read(&vp->common, virtio_pci_common_cfg, queue_enable)) {
+ dprintf(1, "ERROR: queue already active\n");
+ goto fail;
+ }
+ } else {
+ if (vp_read(&vp->legacy, virtio_pci_legacy, queue_pfn)) {
+ dprintf(1, "ERROR: queue already active\n");
+ goto fail;
+ }
}
-
vq->queue_index = queue_index;
/* initialize the queue */
-
struct vring * vr = &vq->vring;
vring_init(vr, num, (unsigned char*)&vq->queue);
@@ -165,9 +179,23 @@ int vp_find_vq(struct vp_device *vp, int queue_index,
* NOTE: vr->desc is initialized by vring_init()
*/
- outl((unsigned long)virt_to_phys(vr->desc) >> PAGE_SHIFT,
- ioaddr + VIRTIO_PCI_QUEUE_PFN);
-
+ if (vp->use_modern) {
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_desc_lo,
+ (unsigned long)virt_to_phys(vr->desc));
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_desc_hi, 0);
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_avail_lo,
+ (unsigned long)virt_to_phys(vr->avail));
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_avail_hi, 0);
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_used_lo,
+ (unsigned long)virt_to_phys(vr->used));
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_used_hi, 0);
+ vp_write(&vp->common, virtio_pci_common_cfg, queue_enable, 1);
+ vq->queue_notify_off = vp_read(&vp->common, virtio_pci_common_cfg,
+ queue_notify_off);
+ } else {
+ vp_write(&vp->legacy, virtio_pci_legacy, queue_pfn,
+ (unsigned long)virt_to_phys(vr->desc) >> PAGE_SHIFT);
+ }
return num;
fail:
--
1.8.3.1
next prev parent reply other threads:[~2015-07-01 14:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 14:40 [Qemu-devel] [PATCH v3 00/25] virtio: add version 1.0 support, move to 32bit Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 01/25] pci: allow to loop over capabilities Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 02/25] virtio: run drivers in 32bit mode Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 03/25] virtio: add struct vp_device Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 04/25] virtio: pass struct pci_device to vp_init_simple Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 05/25] virtio: add version 1.0 structs and #defines Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 06/25] virtio: add version 0.9.5 struct Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 07/25] virtio: find version 1.0 virtio capabilities Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 08/25] virtio: create vp_cap struct for legacy bar Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 09/25] virtio: add read/write functions and macros Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 10/25] virtio: make features 64bit, support version 1.0 features Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 11/25] virtio: add version 1.0 support to vp_{get, set}_status Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 12/25] virtio: add version 1.0 support to vp_get_isr Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 13/25] virtio: add version 1.0 support to vp_reset Gerd Hoffmann
2015-07-01 14:40 ` [Qemu-devel] [PATCH v3 14/25] virtio: add version 1.0 support to vp_notify Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 15/25] virtio: remove unused vp_del_vq Gerd Hoffmann
2015-07-01 14:41 ` Gerd Hoffmann [this message]
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 17/25] virtio-scsi: fix initialization for version 1.0 Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 18/25] virtio-blk: " Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 19/25] virtio: use version 1.0 if available (flip the big switch) Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 20/25] virtio: also probe version 1.0 pci ids Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 21/25] virtio: legacy cleanup Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 22/25] virtio-blk: 32bit cleanup Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 23/25] virtio-scsi: " Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 24/25] virtio-ring: " Gerd Hoffmann
2015-07-01 14:41 ` [Qemu-devel] [PATCH v3 25/25] virtio-pci: use high memory for rings Gerd Hoffmann
2015-07-01 15:21 ` [Qemu-devel] [SeaBIOS] [PATCH v3 00/25] virtio: add version 1.0 support, move to 32bit Kevin O'Connor
2015-07-03 7:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435761670-19520-17-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).