From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 17/17] block: remove redundant check before g_slist_find()
Date: Thu, 2 Jul 2015 10:19:49 +0100 [thread overview]
Message-ID: <1435828789-9647-18-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1435828789-9647-1-git-send-email-stefanha@redhat.com>
From: Alberto Garcia <berto@igalia.com>
An empty GSList is represented by a NULL pointer, therefore it's a
perfectly valid argument for g_slist_find() and there's no need to
make any additional check.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Message-id: 1435583533-5758-1-git-send-email-berto@igalia.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index ad31822..305e0d9 100644
--- a/block/io.c
+++ b/block/io.c
@@ -283,7 +283,7 @@ void bdrv_drain_all(void)
}
aio_context_release(aio_context);
- if (!aio_ctxs || !g_slist_find(aio_ctxs, aio_context)) {
+ if (!g_slist_find(aio_ctxs, aio_context)) {
aio_ctxs = g_slist_prepend(aio_ctxs, aio_context);
}
}
--
2.4.3
next prev parent reply other threads:[~2015-07-02 9:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:19 [Qemu-devel] [PULL 00/17] Block patches Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 01/17] block/iscsi: add support for request timeouts Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 02/17] qcow2: Handle EAGAIN returned from update_refcount Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 03/17] qapi: Rename 'dirty-bitmap' mode to 'incremental' Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_del Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 05/17] timer: Move NANOSECONDS_PER_SECONDS to timer.h Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 06/17] timer: Use a single definition of NSEC_PER_SEC for the whole codebase Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 07/17] block: Add bdrv_get_block_status_above Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 08/17] qmp: Add optional bool "unmap" to drive-mirror Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 09/17] mirror: Do zero write on target if sectors not allocated Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 10/17] block: Fix dirty bitmap in bdrv_co_discard Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 12/17] qemu-iotests: Make block job methods common Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 13/17] qemu-iotests: Add test case for mirror with unmap Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 14/17] iotests: Use event_wait in wait_ready Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 15/17] block/iscsi: restore compatiblity with libiscsi 1.9.0 Stefan Hajnoczi
2015-07-02 9:19 ` [Qemu-devel] [PULL 16/17] block/nfs: limit maximum readahead size to 1MB Stefan Hajnoczi
2015-07-02 9:19 ` Stefan Hajnoczi [this message]
2015-07-02 12:46 ` [Qemu-devel] [PULL 00/17] Block patches Peter Maydell
2015-07-07 13:47 ` Peter Maydell
2015-07-08 13:52 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435828789-9647-18-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).