From: Gerd Hoffmann <kraxel@redhat.com>
To: seabios@seabios.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 1/3] virtio: uninline _vp_{read,write}
Date: Fri, 3 Jul 2015 11:37:36 +0200 [thread overview]
Message-ID: <1435916258-7705-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1435916258-7705-1-git-send-email-kraxel@redhat.com>
Next patch makes it larger, and I don't think it makes sense to
continue inlining it. Uninline and move from header to c file.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
src/hw/virtio-pci.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hw/virtio-pci.h | 79 ++---------------------------------------------------
2 files changed, 80 insertions(+), 77 deletions(-)
diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c
index 6df5194..769710a 100644
--- a/src/hw/virtio-pci.c
+++ b/src/hw/virtio-pci.c
@@ -24,6 +24,84 @@
#include "virtio-pci.h"
#include "virtio-ring.h"
+u64 _vp_read(struct vp_cap *cap, u32 offset, u8 size)
+{
+ u32 addr = cap->addr + offset;
+ u64 var;
+
+ if (cap->is_io) {
+ switch (size) {
+ case 8:
+ var = inl(addr);
+ var |= (u64)inl(addr+4) << 32;
+ break;
+ case 4:
+ var = inl(addr);
+ break;
+ case 2:
+ var = inw(addr);
+ break;
+ case 1:
+ var = inb(addr);
+ break;
+ default:
+ var = 0;
+ }
+ } else {
+ switch (size) {
+ case 8:
+ var = readl((void*)addr);
+ var |= (u64)readl((void*)(addr+4)) << 32;
+ break;
+ case 4:
+ var = readl((void*)addr);
+ break;
+ case 2:
+ var = readw((void*)addr);
+ break;
+ case 1:
+ var = readb((void*)addr);
+ break;
+ default:
+ var = 0;
+ }
+ }
+ dprintf(9, "vp read %x (%d) -> 0x%llx\n", addr, size, var);
+ return var;
+}
+
+void _vp_write(struct vp_cap *cap, u32 offset, u8 size, u64 var)
+{
+ u32 addr = cap->addr + offset;
+
+ dprintf(9, "vp write %x (%d) <- 0x%llx\n", addr, size, var);
+ if (cap->is_io) {
+ switch (size) {
+ case 4:
+ outl(var, addr);
+ break;
+ case 2:
+ outw(var, addr);
+ break;
+ case 1:
+ outb(var, addr);
+ break;
+ }
+ } else {
+ switch (size) {
+ case 4:
+ writel((void*)addr, var);
+ break;
+ case 2:
+ writew((void*)addr, var);
+ break;
+ case 1:
+ writeb((void*)addr, var);
+ break;
+ }
+ }
+}
+
u64 vp_get_features(struct vp_device *vp)
{
u32 f0, f1;
diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h
index b11c355..8d4ebe3 100644
--- a/src/hw/virtio-pci.h
+++ b/src/hw/virtio-pci.h
@@ -98,83 +98,8 @@ struct vp_device {
u8 use_modern;
};
-static inline u64 _vp_read(struct vp_cap *cap, u32 offset, u8 size)
-{
- u32 addr = cap->addr + offset;
- u64 var;
-
- if (cap->is_io) {
- switch (size) {
- case 8:
- var = inl(addr);
- var |= (u64)inl(addr+4) << 32;
- break;
- case 4:
- var = inl(addr);
- break;
- case 2:
- var = inw(addr);
- break;
- case 1:
- var = inb(addr);
- break;
- default:
- var = 0;
- }
- } else {
- switch (size) {
- case 8:
- var = readl((void*)addr);
- var |= (u64)readl((void*)(addr+4)) << 32;
- break;
- case 4:
- var = readl((void*)addr);
- break;
- case 2:
- var = readw((void*)addr);
- break;
- case 1:
- var = readb((void*)addr);
- break;
- default:
- var = 0;
- }
- }
- dprintf(9, "vp read %x (%d) -> 0x%llx\n", addr, size, var);
- return var;
-}
-
-static inline void _vp_write(struct vp_cap *cap, u32 offset, u8 size, u64 var)
-{
- u32 addr = cap->addr + offset;
-
- dprintf(9, "vp write %x (%d) <- 0x%llx\n", addr, size, var);
- if (cap->is_io) {
- switch (size) {
- case 4:
- outl(var, addr);
- break;
- case 2:
- outw(var, addr);
- break;
- case 1:
- outb(var, addr);
- break;
- }
- } else {
- switch (size) {
- case 4:
- writel((void*)addr, var);
- break;
- case 2:
- writew((void*)addr, var);
- break;
- case 1:
- writeb((void*)addr, var);
- break;
- }
- }
-}
+u64 _vp_read(struct vp_cap *cap, u32 offset, u8 size);
+void _vp_write(struct vp_cap *cap, u32 offset, u8 size, u64 var);
#define vp_read(_cap, _struct, _field) \
_vp_read(_cap, offsetof(_struct, _field), \
--
1.8.3.1
next prev parent reply other threads:[~2015-07-03 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 9:37 [Qemu-devel] [PATCH 0/3] virtio: pci cfg access Gerd Hoffmann
2015-07-03 9:37 ` Gerd Hoffmann [this message]
2015-07-03 9:37 ` [Qemu-devel] [PATCH 2/3] " Gerd Hoffmann
2015-07-03 9:37 ` [Qemu-devel] [PATCH 3/3] [testing] map 64bit bars high unconditionally Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435916258-7705-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).