qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails
Date: Fri,  3 Jul 2015 17:50:21 -0300	[thread overview]
Message-ID: <1435956624-21609-4-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1435956624-21609-1-git-send-email-ehabkost@redhat.com>

From: Bharata B Rao <bharata@linux.vnet.ibm.com>

HotplugHandlerClass::plug() shouldn't fail and hence use error_abort
to abort if it fails.

Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Tested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8df1f3e..a66416d 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
     }
 
     hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
-    hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
+    hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort);
 out:
     error_propagate(errp, local_err);
 }
-- 
2.1.0

  parent reply	other threads:[~2015-07-03 20:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03 20:50 [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03 Eduardo Habkost
2015-07-03 20:50 ` [Qemu-devel] [PULL 1/6] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure Eduardo Habkost
2015-07-03 20:50 ` [Qemu-devel] [PULL 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine Eduardo Habkost
2015-07-03 20:50 ` Eduardo Habkost [this message]
2015-07-03 20:50 ` [Qemu-devel] [PULL 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info Eduardo Habkost
2015-07-03 20:50 ` [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info Eduardo Habkost
2015-07-09 14:12   ` Paolo Bonzini
2015-07-09 15:10     ` Bharata B Rao
2015-07-09 15:18       ` Paolo Bonzini
2015-07-03 20:50 ` [Qemu-devel] [PULL 6/6] numa: API to lookup NUMA node by address Eduardo Habkost
2015-07-05 19:35 ` [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435956624-21609-4-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).