From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB7v1-00022Z-GW for qemu-devel@nongnu.org; Fri, 03 Jul 2015 16:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZB7v0-0005pw-2K for qemu-devel@nongnu.org; Fri, 03 Jul 2015 16:50:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB7uz-0005pm-Sy for qemu-devel@nongnu.org; Fri, 03 Jul 2015 16:50:41 -0400 From: Eduardo Habkost Date: Fri, 3 Jul 2015 17:50:21 -0300 Message-Id: <1435956624-21609-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1435956624-21609-1-git-send-email-ehabkost@redhat.com> References: <1435956624-21609-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Bharata B Rao , qemu-devel@nongnu.org, "Michael S. Tsirkin" From: Bharata B Rao HotplugHandlerClass::plug() shouldn't fail and hence use error_abort to abort if it fails. Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8df1f3e..a66416d 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, } hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); - hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); + hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort); out: error_propagate(errp, local_err); } -- 2.1.0