From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com
Subject: [Qemu-devel] [PULL 18/35] libqos/ahci: Force all NCQ commands to be LBA48
Date: Sat, 4 Jul 2015 02:06:57 -0400 [thread overview]
Message-ID: <1435990034-8945-19-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1435990034-8945-1-git-send-email-jsnow@redhat.com>
NCQ commands are LBA48 by definition.
See SATA 3.2 13.6.4.1 "READ FPDMA QUEUED", or
SATA 3.2 13.6.5.1 "WRITE FPDMA QUEUED."
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1435016308-6150-15-git-send-email-jsnow@redhat.com
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 7cf667a..3d62cb6 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -781,7 +781,7 @@ void ahci_command_set_offset(AHCICommand *cmd, uint64_t lba_sect)
RegH2DFIS *fis = &(cmd->fis);
if (cmd->props->lba28) {
g_assert_cmphex(lba_sect, <=, 0xFFFFFFF);
- } else if (cmd->props->lba48) {
+ } else if (cmd->props->lba48 || cmd->props->ncq) {
g_assert_cmphex(lba_sect, <=, 0xFFFFFFFFFFFF);
} else {
/* Can't set offset if we don't know the format. */
--
2.1.0
next prev parent reply other threads:[~2015-07-04 6:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 6:06 [Qemu-devel] [PULL 00/35] Ide patches John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 01/35] ahci: Do not ignore memory access read size John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 02/35] qtest/ahci: add test_max John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 03/35] libqos/ahci: fix memory management bugs John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 04/35] qtest/ahci: add port_reset test John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 05/35] ahci: Rename NCQFIS structure fields John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 06/35] ahci: use shorter variables John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 07/35] ahci: add ncq_err helper John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 08/35] ahci: check for ncq prdtl overflow John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 09/35] ahci: separate prdtl from opts John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 10/35] ahci: add ncq debug checks John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 11/35] ahci: ncq sector count correction John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 12/35] ahci/qtest: Execute IDENTIFY prior to data commands John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 13/35] libqos/ahci: fix cmd_sanity for ncq John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 14/35] libqos/ahci: add NCQ frame support John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 15/35] libqos/ahci: edit wait to be ncq aware John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 16/35] libqos/ahci: adjust expected NCQ interrupts John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 17/35] libqos/ahci: set the NCQ tag on command_commit John Snow
2015-07-04 6:06 ` John Snow [this message]
2015-07-04 6:06 ` [Qemu-devel] [PULL 19/35] qtest/ahci: simple ncq data test John Snow
2015-07-04 6:06 ` [Qemu-devel] [PULL 20/35] qtest/ahci: ncq migration test John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 21/35] ide: add limit to .prepare_buf() John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 22/35] ahci: stash ncq command John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 23/35] ahci: assert is_ncq for process_ncq John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 24/35] ahci: refactor process_ncq_command John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 25/35] ahci: factor ncq_finish out of ncq_cb John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 26/35] ahci: add rwerror=stop support for ncq John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 27/35] ahci: correct types in NCQTransferState John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 28/35] ahci: correct ncq sector count John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 29/35] qtest/ahci: halted NCQ test John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 30/35] ahci: add cmd header to ncq transfer state John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 31/35] ahci: add get_cmd_header helper John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 32/35] ahci: ncq migration John Snow
2015-07-09 14:11 ` Paolo Bonzini
2015-07-04 6:07 ` [Qemu-devel] [PULL 33/35] ahci: Do not map cmd_fis to generate response John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 34/35] qtest/ahci: halted ncq migration test John Snow
2015-07-04 6:07 ` [Qemu-devel] [PULL 35/35] ahci: fix sdb fis semantics John Snow
2015-07-05 21:01 ` [Qemu-devel] [PULL 00/35] Ide patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435990034-8945-19-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).