From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBGbt-0006Xb-QF for qemu-devel@nongnu.org; Sat, 04 Jul 2015 02:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBGbp-0003X6-GL for qemu-devel@nongnu.org; Sat, 04 Jul 2015 02:07:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBGbp-0003Wr-BZ for qemu-devel@nongnu.org; Sat, 04 Jul 2015 02:07:29 -0400 From: John Snow Date: Sat, 4 Jul 2015 02:06:57 -0400 Message-Id: <1435990034-8945-19-git-send-email-jsnow@redhat.com> In-Reply-To: <1435990034-8945-1-git-send-email-jsnow@redhat.com> References: <1435990034-8945-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PULL 18/35] libqos/ahci: Force all NCQ commands to be LBA48 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jsnow@redhat.com NCQ commands are LBA48 by definition. See SATA 3.2 13.6.4.1 "READ FPDMA QUEUED", or SATA 3.2 13.6.5.1 "WRITE FPDMA QUEUED." Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Message-id: 1435016308-6150-15-git-send-email-jsnow@redhat.com --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index 7cf667a..3d62cb6 100644 --- a/tests/libqos/ahci.c +++ b/tests/libqos/ahci.c @@ -781,7 +781,7 @@ void ahci_command_set_offset(AHCICommand *cmd, uint64_t lba_sect) RegH2DFIS *fis = &(cmd->fis); if (cmd->props->lba28) { g_assert_cmphex(lba_sect, <=, 0xFFFFFFF); - } else if (cmd->props->lba48) { + } else if (cmd->props->lba48 || cmd->props->ncq) { g_assert_cmphex(lba_sect, <=, 0xFFFFFFFFFFFF); } else { /* Can't set offset if we don't know the format. */ -- 2.1.0