qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/7] target-arm: fix write helper for TLBI ALLE1IS
Date: Mon,  6 Jul 2015 10:59:29 +0100	[thread overview]
Message-ID: <1436176775-29545-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1436176775-29545-1-git-send-email-peter.maydell@linaro.org>

From: Sergey Fedorov <serge.fdrv@gmail.com>

TLBI ALLE1IS is an operation that does invalidate TLB entries on all PEs
in the same Inner Sharable domain, not just on the current CPU. So we
must use tlbiall_is_write() here.

Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Message-id: 1435676538-31345-1-git-send-email-serge.fdrv@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index aa34159..b87afe7 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -2441,7 +2441,7 @@ static const ARMCPRegInfo v8_cp_reginfo[] = {
     { .name = "TLBI_ALLE1IS", .state = ARM_CP_STATE_AA64,
       .opc0 = 1, .opc1 = 4, .crn = 8, .crm = 3, .opc2 = 4,
       .access = PL2_W, .type = ARM_CP_NO_RAW,
-      .writefn = tlbiall_write },
+      .writefn = tlbiall_is_write },
     { .name = "TLBI_VMALLE1IS", .state = ARM_CP_STATE_AA64,
       .opc0 = 1, .opc1 = 0, .crn = 8, .crm = 3, .opc2 = 0,
       .access = PL1_W, .type = ARM_CP_NO_RAW,
-- 
1.9.1

  reply	other threads:[~2015-07-06  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06  9:59 [Qemu-devel] [PULL 0/7] target-arm queue Peter Maydell
2015-07-06  9:59 ` Peter Maydell [this message]
2015-07-06  9:59 ` [Qemu-devel] [PULL 2/7] Fix interval interrupt of cadence ttc when timer is in decrement mode Peter Maydell
2015-07-06  9:59 ` [Qemu-devel] [PULL 3/7] target-arm: Split DISAS_YIELD from DISAS_WFE Peter Maydell
2015-07-06  9:59 ` [Qemu-devel] [PULL 4/7] target-arm: Implement YIELD insn to yield in ARM and Thumb translators Peter Maydell
2015-07-06  9:59 ` [Qemu-devel] [PULL 5/7] hw/intc/arm_gic_common.c: Reset all registers Peter Maydell
2015-07-06  9:59 ` [Qemu-devel] [PULL 6/7] arm_mptimer: Fix timer shutdown and mode change Peter Maydell
2015-07-06  9:59 ` [Qemu-devel] [PULL 7/7] arm_mptimer: Respect IT bit state Peter Maydell
2015-07-06 11:51 ` [Qemu-devel] [PULL 0/7] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436176775-29545-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).