qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PULL 15/22] microblaze: boot: Use cpu_set_pc()
Date: Tue,  7 Jul 2015 01:13:58 +0200	[thread overview]
Message-ID: <1436224445-19449-16-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1436224445-19449-1-git-send-email-afaerber@suse.de>

From: Peter Crosthwaite <crosthwaitepeter@gmail.com>

Use cpu_set_pc() for setting program counters when bootloading. This
removes an instance of system level code having to reach into the CPU
env.

Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
[AF: Avoid duplicated CPU() casts through local variable]
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/microblaze/boot.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c
index 4c44317..3e8820f 100644
--- a/hw/microblaze/boot.c
+++ b/hw/microblaze/boot.c
@@ -48,13 +48,14 @@ static struct
 static void main_cpu_reset(void *opaque)
 {
     MicroBlazeCPU *cpu = opaque;
+    CPUState *cs = CPU(cpu);
     CPUMBState *env = &cpu->env;
 
-    cpu_reset(CPU(cpu));
+    cpu_reset(cs);
     env->regs[5] = boot_info.cmdline;
     env->regs[6] = boot_info.initrd_start;
     env->regs[7] = boot_info.fdt;
-    env->sregs[SR_PC] = boot_info.bootstrap_pc;
+    cpu_set_pc(cs, boot_info.bootstrap_pc);
     if (boot_info.machine_cpu_reset) {
         boot_info.machine_cpu_reset(cpu);
     }
-- 
2.1.4

  parent reply	other threads:[~2015-07-06 23:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 23:13 [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 01/22] cpu: No need to zero-initialize CPUState::numa_node Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 02/22] cpu: Initialize breakpoint/watchpoint lists in cpu_common_initfn() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 03/22] cpu: Reorder cpu->as, cpu->thread_id, cpu->memory_dispatch init Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 04/22] cpu: Add Error argument to cpu_exec_init() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 05/22] cpu: Convert cpu_index into a bitmap Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 06/22] target-ppc: Move cpu_exec_init() call to realize function Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 07/22] translate-all: Change tb_flush() env argument to cpu Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 08/22] gdbstub: Change gdbserver_fork() to accept cpu instead of env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 09/22] cpu: Change tcg_cpu_exec() arg to cpu, not env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 10/22] cpu: Change cpu_exec_init() " Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 11/22] cpu-exec: Purge all uses of ENV_GET_CPU() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 12/22] cpu: Add wrapper for the set_pc() hook Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 13/22] gdbstub: Use cpu_set_pc() helper Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 14/22] hw/arm/boot: Use cpu_set_pc() Andreas Färber
2015-07-06 23:13 ` Andreas Färber [this message]
2015-07-06 23:13 ` [Qemu-devel] [PULL 16/22] disas: Add print_insn to disassemble info Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 17/22] disas: QOMify target specific setup Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 18/22] disas: arm-a64: Make printfer and stream variable Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 19/22] disas: arm: QOMify target specific disas setup Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 20/22] disas: microblaze: " Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 21/22] disas: cris: Fix 0 buffer length case Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 22/22] disas: cris: QOMify target specific disas setup Andreas Färber
2015-07-07  0:24 ` [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-07  2:25   ` Peter Crosthwaite
2015-07-07  3:56     ` Bharata B Rao
2015-07-07  4:14       ` Peter Crosthwaite
2015-07-07  4:07     ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436224445-19449-16-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).