qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PULL 18/22] disas: arm-a64: Make printfer and stream variable
Date: Tue,  7 Jul 2015 01:14:01 +0200	[thread overview]
Message-ID: <1436224445-19449-19-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1436224445-19449-1-git-send-email-afaerber@suse.de>

From: Peter Crosthwaite <crosthwaitepeter@gmail.com>

In a normal disassembly flow, the printf() and stream being used varies
from disas job to job. In particular it varies if mixing monitor_disas
and target_disas.

Make both the printf() function and target stream settable in the
QEMUDisassmbler class.

Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
Tested-by: Claudio Fontana <claudio.fontana@huawei.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 disas/arm-a64.cc | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/disas/arm-a64.cc b/disas/arm-a64.cc
index e04f946..b0803f9 100644
--- a/disas/arm-a64.cc
+++ b/disas/arm-a64.cc
@@ -35,16 +35,25 @@ static Disassembler *vixl_disasm = NULL;
  */
 class QEMUDisassembler : public Disassembler {
 public:
-    explicit QEMUDisassembler(FILE *stream) : stream_(stream) { }
+    QEMUDisassembler() : printf_(NULL), stream_(NULL) { }
     ~QEMUDisassembler() { }
 
+    void SetStream(FILE *stream) {
+        stream_ = stream;
+    }
+
+    void SetPrintf(int (*printf_fn)(FILE *, const char *, ...)) {
+        printf_ = printf_fn;
+    }
+
 protected:
     virtual void ProcessOutput(const Instruction *instr) {
-        fprintf(stream_, "%08" PRIx32 "      %s",
+        printf_(stream_, "%08" PRIx32 "      %s",
                 instr->InstructionBits(), GetOutput());
     }
 
 private:
+    int (*printf_)(FILE *, const char *, ...);
     FILE *stream_;
 };
 
@@ -53,9 +62,9 @@ static int vixl_is_initialized(void)
     return vixl_decoder != NULL;
 }
 
-static void vixl_init(FILE *f) {
+static void vixl_init() {
     vixl_decoder = new Decoder();
-    vixl_disasm = new QEMUDisassembler(f);
+    vixl_disasm = new QEMUDisassembler();
     vixl_decoder->AppendVisitor(vixl_disasm);
 }
 
@@ -78,9 +87,12 @@ int print_insn_arm_a64(uint64_t addr, disassemble_info *info)
     }
 
     if (!vixl_is_initialized()) {
-        vixl_init(info->stream);
+        vixl_init();
     }
 
+    ((QEMUDisassembler *)vixl_disasm)->SetPrintf(info->fprintf_func);
+    ((QEMUDisassembler *)vixl_disasm)->SetStream(info->stream);
+
     instrval = bytes[0] | bytes[1] << 8 | bytes[2] << 16 | bytes[3] << 24;
     instr = reinterpret_cast<const Instruction *>(&instrval);
     vixl_disasm->MapCodeAddress(addr, instr);
-- 
2.1.4

  parent reply	other threads:[~2015-07-06 23:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 23:13 [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 01/22] cpu: No need to zero-initialize CPUState::numa_node Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 02/22] cpu: Initialize breakpoint/watchpoint lists in cpu_common_initfn() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 03/22] cpu: Reorder cpu->as, cpu->thread_id, cpu->memory_dispatch init Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 04/22] cpu: Add Error argument to cpu_exec_init() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 05/22] cpu: Convert cpu_index into a bitmap Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 06/22] target-ppc: Move cpu_exec_init() call to realize function Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 07/22] translate-all: Change tb_flush() env argument to cpu Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 08/22] gdbstub: Change gdbserver_fork() to accept cpu instead of env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 09/22] cpu: Change tcg_cpu_exec() arg to cpu, not env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 10/22] cpu: Change cpu_exec_init() " Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 11/22] cpu-exec: Purge all uses of ENV_GET_CPU() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 12/22] cpu: Add wrapper for the set_pc() hook Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 13/22] gdbstub: Use cpu_set_pc() helper Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 14/22] hw/arm/boot: Use cpu_set_pc() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 15/22] microblaze: boot: " Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 16/22] disas: Add print_insn to disassemble info Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 17/22] disas: QOMify target specific setup Andreas Färber
2015-07-06 23:14 ` Andreas Färber [this message]
2015-07-06 23:14 ` [Qemu-devel] [PULL 19/22] disas: arm: QOMify target specific disas setup Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 20/22] disas: microblaze: " Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 21/22] disas: cris: Fix 0 buffer length case Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 22/22] disas: cris: QOMify target specific disas setup Andreas Färber
2015-07-07  0:24 ` [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-07  2:25   ` Peter Crosthwaite
2015-07-07  3:56     ` Bharata B Rao
2015-07-07  4:14       ` Peter Crosthwaite
2015-07-07  4:07     ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436224445-19449-19-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).