From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PULL 02/22] cpu: Initialize breakpoint/watchpoint lists in cpu_common_initfn()
Date: Tue, 7 Jul 2015 01:13:45 +0200 [thread overview]
Message-ID: <1436224445-19449-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1436224445-19449-1-git-send-email-afaerber@suse.de>
From: Eduardo Habkost <ehabkost@redhat.com>
One small step in the simplification of cpu_exec_init().
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
exec.c | 2 --
qom/cpu.c | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index e63f748..b5ff469 100644
--- a/exec.c
+++ b/exec.c
@@ -541,8 +541,6 @@ void cpu_exec_init(CPUArchState *env)
cpu_index++;
}
cpu->cpu_index = cpu_index;
- QTAILQ_INIT(&cpu->breakpoints);
- QTAILQ_INIT(&cpu->watchpoints);
#ifndef CONFIG_USER_ONLY
cpu->as = &address_space_memory;
cpu->thread_id = qemu_get_thread_id();
diff --git a/qom/cpu.c b/qom/cpu.c
index 108bfa2..56c53a8 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -313,6 +313,8 @@ static void cpu_common_initfn(Object *obj)
CPUClass *cc = CPU_GET_CLASS(obj);
cpu->gdb_num_regs = cpu->gdb_num_g_regs = cc->gdb_num_core_regs;
+ QTAILQ_INIT(&cpu->breakpoints);
+ QTAILQ_INIT(&cpu->watchpoints);
}
static int64_t cpu_common_get_arch_id(CPUState *cpu)
--
2.1.4
next prev parent reply other threads:[~2015-07-06 23:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 23:13 [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 01/22] cpu: No need to zero-initialize CPUState::numa_node Andreas Färber
2015-07-06 23:13 ` Andreas Färber [this message]
2015-07-06 23:13 ` [Qemu-devel] [PULL 03/22] cpu: Reorder cpu->as, cpu->thread_id, cpu->memory_dispatch init Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 04/22] cpu: Add Error argument to cpu_exec_init() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 05/22] cpu: Convert cpu_index into a bitmap Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 06/22] target-ppc: Move cpu_exec_init() call to realize function Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 07/22] translate-all: Change tb_flush() env argument to cpu Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 08/22] gdbstub: Change gdbserver_fork() to accept cpu instead of env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 09/22] cpu: Change tcg_cpu_exec() arg to cpu, not env Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 10/22] cpu: Change cpu_exec_init() " Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 11/22] cpu-exec: Purge all uses of ENV_GET_CPU() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 12/22] cpu: Add wrapper for the set_pc() hook Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 13/22] gdbstub: Use cpu_set_pc() helper Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 14/22] hw/arm/boot: Use cpu_set_pc() Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 15/22] microblaze: boot: " Andreas Färber
2015-07-06 23:13 ` [Qemu-devel] [PULL 16/22] disas: Add print_insn to disassemble info Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 17/22] disas: QOMify target specific setup Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 18/22] disas: arm-a64: Make printfer and stream variable Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 19/22] disas: arm: QOMify target specific disas setup Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 20/22] disas: microblaze: " Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 21/22] disas: cris: Fix 0 buffer length case Andreas Färber
2015-07-06 23:14 ` [Qemu-devel] [PULL 22/22] disas: cris: QOMify target specific disas setup Andreas Färber
2015-07-07 0:24 ` [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06 Andreas Färber
2015-07-07 2:25 ` Peter Crosthwaite
2015-07-07 3:56 ` Bharata B Rao
2015-07-07 4:14 ` Peter Crosthwaite
2015-07-07 4:07 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436224445-19449-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).