From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: "Denis V. Lunev" <den@openvz.org>,
peter.maydell@linaro.org, Olga Krishtal <okrishtal@virtuozzo.com>
Subject: [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.
Date: Mon, 6 Jul 2015 23:40:17 -0500 [thread overview]
Message-ID: <1436244020-27822-8-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1436244020-27822-1-git-send-email-mdroth@linux.vnet.ibm.com>
From: Olga Krishtal <okrishtal@virtuozzo.com>
We need qmp_quest_get_fsinfo togather with vss-provider, which works with
volumes. The call to this function is implemented via
FindFirst/NextVolumes. Moreover, volumes in Windows OS are filesystem unit,
so it will be more effective to work with them rather with devices.
Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Eric Blake <eblake@redhat.com>
CC: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/commands-win32.c | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index e8769bb..3f3a144 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -390,8 +390,29 @@ static void guest_file_init(void)
GuestFilesystemInfoList *qmp_guest_get_fsinfo(Error **errp)
{
- error_setg(errp, QERR_UNSUPPORTED);
- return NULL;
+ HANDLE vol_h;
+ GuestFilesystemInfoList *new, *ret = NULL;
+ char guid[256];
+
+ vol_h = FindFirstVolume(guid, sizeof(guid));
+ if (vol_h == INVALID_HANDLE_VALUE) {
+ error_setg_win32(errp, GetLastError(), "failed to find any volume");
+ return NULL;
+ }
+
+ do {
+ new = g_malloc(sizeof(*ret));
+ new->value = build_guest_fsinfo(guid, errp);
+ new->next = ret;
+ ret = new;
+ } while (FindNextVolume(vol_h, guid, sizeof(guid)));
+
+ if (GetLastError() != ERROR_NO_MORE_FILES) {
+ error_setg_win32(errp, GetLastError(), "failed to find next volume");
+ }
+
+ FindVolumeClose(vol_h);
+ return ret;
}
/*
@@ -928,7 +949,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
"guest-set-user-password",
"guest-get-memory-blocks", "guest-set-memory-blocks",
"guest-get-memory-block-size",
- "guest-fsfreeze-freeze-list", "guest-get-fsinfo",
+ "guest-fsfreeze-freeze-list",
"guest-fstrim", NULL};
char **p = (char **)list_unsupported;
--
1.9.1
next prev parent reply other threads:[~2015-07-07 4:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 4:40 [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0 Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 01/10] qga/commands-posix: Fix bug in guest-fstrim Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 02/10] qga/qmp_guest_fstrim: Return per path fstrim result Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 03/10] Revert "guest agent: remove g_strcmp0 usage" Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 04/10] qga: add win32 library iphlpapi Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 05/10] qga: win32 qmp_guest_network_get_interfaces implementation Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 06/10] qga: fail early for invalid time Michael Roth
2015-07-07 4:40 ` Michael Roth [this message]
2015-07-07 4:40 ` [Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume Michael Roth
2015-07-07 4:40 ` [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path Michael Roth
2015-07-20 15:06 ` Eric Blake
2015-07-20 15:19 ` Denis V. Lunev
2015-07-07 4:40 ` [Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information Michael Roth
2015-07-07 10:32 ` [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0 Peter Maydell
2015-07-07 13:06 ` Olga Krishtal
2015-07-07 13:15 ` Peter Maydell
2015-07-07 13:18 ` Peter Maydell
2015-07-07 13:25 ` Olga Krishtal
2015-07-07 13:30 ` Peter Maydell
2015-07-07 17:13 ` [Qemu-devel] [PATCH] qga: fix build for older versions of mingw Olga Krishtal
2015-07-07 18:06 ` Denis V. Lunev
2015-07-07 19:16 ` Peter Maydell
2015-07-07 20:02 ` Michael Roth
2015-07-07 20:04 ` Denis V. Lunev
2015-07-07 21:23 ` Michael Roth
2015-07-07 21:28 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2015-06-30 10:25 [Qemu-devel] [PATCH v6 0/10] QGA: disk and volume info for Windows & guest exec Denis V. Lunev
2015-06-30 10:25 ` [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality Denis V. Lunev
2015-06-19 16:57 [Qemu-devel] [PATCH v5 0/10] QGA: disk and volume info for Windows & guest exec Denis V. Lunev
2015-06-19 16:57 ` [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality Denis V. Lunev
2015-06-19 16:51 [Qemu-devel] [PATCH v4 0/10] QGA: disk and volume info for Windows & guest exec Denis V. Lunev
2015-06-19 16:51 ` [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436244020-27822-8-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=den@openvz.org \
--cc=okrishtal@virtuozzo.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).