* [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send()
@ 2015-07-07 9:00 Jason Wang
2015-07-07 9:09 ` Fam Zheng
2015-07-09 9:41 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Jason Wang @ 2015-07-07 9:00 UTC (permalink / raw)
To: stefanha, qemu-devel; +Cc: Jason Wang, famz
We should pass the size of packet instead of the remaining to
qemu_send_packet_async().
Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a
("net/socket: Drop net_socket_can_send")
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index c752696..b1e3b1c 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -213,7 +213,7 @@ static void net_socket_send(void *opaque)
if (s->index >= s->packet_len) {
s->index = 0;
s->state = 0;
- if (qemu_send_packet_async(&s->nc, s->buf, size,
+ if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len,
net_socket_send_completed) == 0) {
net_socket_read_poll(s, false);
break;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send()
2015-07-07 9:00 [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send() Jason Wang
@ 2015-07-07 9:09 ` Fam Zheng
2015-07-09 9:41 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2015-07-07 9:09 UTC (permalink / raw)
To: Jason Wang; +Cc: qemu-devel, stefanha
On Tue, 07/07 17:00, Jason Wang wrote:
> We should pass the size of packet instead of the remaining to
> qemu_send_packet_async().
>
> Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a
> ("net/socket: Drop net_socket_can_send")
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Thanks!
Reviewed-by: Fam Zheng <famz@redhat.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index c752696..b1e3b1c 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -213,7 +213,7 @@ static void net_socket_send(void *opaque)
> if (s->index >= s->packet_len) {
> s->index = 0;
> s->state = 0;
> - if (qemu_send_packet_async(&s->nc, s->buf, size,
> + if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len,
> net_socket_send_completed) == 0) {
> net_socket_read_poll(s, false);
> break;
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send()
2015-07-07 9:00 [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send() Jason Wang
2015-07-07 9:09 ` Fam Zheng
@ 2015-07-09 9:41 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-07-09 9:41 UTC (permalink / raw)
To: Jason Wang; +Cc: famz, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Tue, Jul 07, 2015 at 05:00:56PM +0800, Jason Wang wrote:
> We should pass the size of packet instead of the remaining to
> qemu_send_packet_async().
>
> Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a
> ("net/socket: Drop net_socket_can_send")
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-09 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 9:00 [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send() Jason Wang
2015-07-07 9:09 ` Fam Zheng
2015-07-09 9:41 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).