qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, peter.maydell@linaro.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH] s390/virtio-ccw: Fix migration
Date: Tue,  7 Jul 2015 13:47:23 +0200	[thread overview]
Message-ID: <1436269643-66303-1-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <559BB8D6.4050404@de.ibm.com>

commit 213941d73b ("virtio-ccw: migrate ->revision") broke
migration:
2015-07-07T11:22:55.570968Z qemu-system-s390x: VQ 39 address 0x0 inconsistent with Host index 0x100
2015-07-07T11:22:55.571008Z qemu-system-s390x: error while loading state for instance 0x0 of

If thinint support is active, the config_load function returns early.
Make sure to load the revision all the time.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Fixes: 213941d73b ("virtio-ccw: migrate ->revision")
---
 hw/s390x/virtio-ccw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index d631337..cc74c5c 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1508,12 +1508,12 @@ static int virtio_ccw_load_config(DeviceState *d, QEMUFile *f)
     qemu_get_be16s(f, &vdev->config_vector);
     dev->routes.adapter.ind_offset = qemu_get_be64(f);
     dev->thinint_isc = qemu_get_byte(f);
+    dev->revision = qemu_get_be32(f);
     if (s->thinint_active) {
         return css_register_io_adapter(CSS_IO_ADAPTER_VIRTIO,
                                        dev->thinint_isc, true, false,
                                        &dev->routes.adapter.adapter_id);
     }
-    dev->revision = qemu_get_be32(f);
 
     return 0;
 }
-- 
2.3.0

  reply	other threads:[~2015-07-07 11:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 14:10 [Qemu-devel] [PULL v3 for-2.4 00/11] s390x patches for 2.4 Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 01/11] virtio-ccw: complete handling of guest-initiated resets Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 02/11] css: mss/mcss-e vs. migration Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 03/11] s390-ccw.img: Consume service interrupts Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 04/11] s390-ccw.img: update Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 05/11] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 06/11] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 07/11] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 08/11] virtio-ccw: migrate ->revision Cornelia Huck
2015-07-07 11:32   ` Christian Borntraeger
2015-07-07 11:47     ` Christian Borntraeger [this message]
2015-07-07 14:24       ` [Qemu-devel] [PATCH] s390/virtio-ccw: Fix migration Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 09/11] s390x/ipl: Fix boot if no bootindex was specified Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 10/11] s390x/gdb: synchronize cpu state after modifying acrs Cornelia Huck
2015-07-02 14:10 ` [Qemu-devel] [PULL v3 for-2.4 11/11] s390x/migration: Introduce 2.4 machine Cornelia Huck
2015-07-02 15:25 ` [Qemu-devel] [PULL v3 for-2.4 00/11] s390x patches for 2.4 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436269643-66303-1-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).