From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCSd8-00055D-O1 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:09:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCSd6-0003ZW-EM for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:09:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCSd6-0003Yv-A0 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:09:44 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 115F2A12C8 for ; Tue, 7 Jul 2015 13:09:44 +0000 (UTC) From: Juan Quintela Date: Tue, 7 Jul 2015 15:09:02 +0200 Message-Id: <1436274549-28826-22-git-send-email-quintela@redhat.com> In-Reply-To: <1436274549-28826-1-git-send-email-quintela@redhat.com> References: <1436274549-28826-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PULL 21/28] migration: Use always helper to set state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: amit.shah@redhat.com There were three places that were not using the migrate_set_state() helper, just fix that. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 5c1233f..78eb715 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -549,7 +549,7 @@ void migrate_fd_error(MigrationState *s) { trace_migrate_fd_error(); assert(s->file == NULL); - s->state = MIGRATION_STATUS_FAILED; + migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); trace_migrate_set_state(MIGRATION_STATUS_FAILED); notifier_list_notify(&migration_state_notifiers, s); } @@ -634,7 +634,7 @@ static MigrationState *migrate_init(const MigrationParams *params) s->parameters[MIGRATION_PARAMETER_DECOMPRESS_THREADS] = decompress_thread_count; s->bandwidth_limit = bandwidth_limit; - s->state = MIGRATION_STATUS_SETUP; + migrate_set_state(s, MIGRATION_STATUS_NONE, MIGRATION_STATUS_SETUP); trace_migrate_set_state(MIGRATION_STATUS_SETUP); s->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); @@ -733,7 +733,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, } else { error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "uri", "a valid migration protocol"); - s->state = MIGRATION_STATUS_FAILED; + migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); return; } -- 2.4.3