From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCSwk-0006Kq-Rc for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCSwe-0006mA-K5 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:30:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCSwe-0006lc-30 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 09:29:56 -0400 From: Stefan Hajnoczi Date: Tue, 7 Jul 2015 14:29:46 +0100 Message-Id: <1436275791-535-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1436275791-535-1-git-send-email-stefanha@redhat.com> References: <1436275791-535-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL for-2.4 v2 1/6] qcow2: remove unnecessary check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Alberto Garcia , Stefan Hajnoczi From: Alberto Garcia The value of 'i' is guaranteed to be >= 0 Signed-off-by: Alberto Garcia Message-id: 1435824371-2660-1-git-send-email-berto@igalia.com Signed-off-by: Stefan Hajnoczi --- block/qcow2-cache.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index ed92a09..53b8afc 100644 --- a/block/qcow2-cache.c +++ b/block/qcow2-cache.c @@ -281,9 +281,6 @@ static int qcow2_cache_do_get(BlockDriverState *bs, Qcow2Cache *c, i = min_lru_index; trace_qcow2_cache_get_replace_entry(qemu_coroutine_self(), c == s->l2_table_cache, i); - if (i < 0) { - return i; - } ret = qcow2_cache_entry_flush(bs, c, i); if (ret < 0) { -- 2.4.3