From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCusT-0008Vf-D0 for qemu-devel@nongnu.org; Wed, 08 Jul 2015 15:19:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCusO-0001Ce-Hf for qemu-devel@nongnu.org; Wed, 08 Jul 2015 15:19:29 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCusO-0001Ag-BI for qemu-devel@nongnu.org; Wed, 08 Jul 2015 15:19:24 -0400 From: Konrad Rzeszutek Wilk Date: Wed, 8 Jul 2015 15:19:12 -0400 Message-Id: <1436383152-18033-2-git-send-email-konrad.wilk@oracle.com> In-Reply-To: <1436383152-18033-1-git-send-email-konrad.wilk@oracle.com> References: <1435866681-18468-1-git-send-email-konrad.wilk@oracle.com> <1436383152-18033-1-git-send-email-konrad.wilk@oracle.com> Subject: [Qemu-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, JBeulich@suse.com Cc: Konrad Rzeszutek Wilk Instead we have the emulation registers ->init functions which consult the host values to see what the initial value should be and they are responsible for populating the dev.config. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 05828e0..cd69cb4 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -780,12 +780,7 @@ static int xen_pt_initfn(PCIDevice *d) } /* Initialize virtualized PCI configuration (Extended 256 Bytes) */ - rc = xen_host_pci_get_block(&s->real_device, 0, d->config, - PCI_CONFIG_SPACE_SIZE); - if (rc < 0) { - XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc); - goto err_out; - } + memset(d->config, 0, PCI_CONFIG_SPACE_SIZE); s->memory_listener = xen_pt_memory_listener; s->io_listener = xen_pt_io_listener; -- 1.8.4.2