qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: hw.claudio@gmail.com
To: qemu-devel@nongnu.org
Cc: Marc Zyngier <marc.zyngier@arm.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Claudio Fontana <claudio.fontana@huawei.com>
Subject: [Qemu-devel] [RFC] target-arm: do not change CNTVOFF_EL2
Date: Thu,  9 Jul 2015 16:38:09 +0200	[thread overview]
Message-ID: <1436452689-11159-1-git-send-email-hw.claudio@gmail.com> (raw)

From: Claudio Fontana <claudio.fontana@huawei.com>

after a vm is created, the cntvoff_el2 is already calculated
for us by kvm, do not attempt to change it.

Signed-off-by: Claudio Fontana <claudio.fontana@huawei.com>
---
 target-arm/kvm.c | 5 +++++
 1 file changed, 5 insertions(+)

This is just an RFC to show where QEMU is causing the change
of CNTVOFF_EL2. This fixes the issue for me, but maybe this
is not the right way to do it?

Thanks,

Claudio

diff --git a/target-arm/kvm.c b/target-arm/kvm.c
index 548bfd7..c5ad580 100644
--- a/target-arm/kvm.c
+++ b/target-arm/kvm.c
@@ -421,6 +421,11 @@ bool write_list_to_kvmstate(ARMCPU *cpu)
         uint32_t v32;
         int ret;
 
+	if (regidx == KVM_REG_ARM_TIMER_CNT) {
+            /* do not cause a change of CNTVOFF_EL2. */
+            continue;
+	}
+
         r.id = regidx;
         switch (regidx & KVM_REG_SIZE_MASK) {
         case KVM_REG_SIZE_U32:
-- 
1.8.5.3

             reply	other threads:[~2015-07-09 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 14:38 hw.claudio [this message]
2015-07-09 15:08 ` [Qemu-devel] [RFC] target-arm: do not change CNTVOFF_EL2 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436452689-11159-1-git-send-email-hw.claudio@gmail.com \
    --to=hw.claudio@gmail.com \
    --cc=claudio.fontana@huawei.com \
    --cc=marc.zyngier@arm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).