qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: <arei.gonglei@huawei.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	Gonglei <arei.gonglei@huawei.com>
Subject: [Qemu-devel] [PATCH 1/4] cpu: fix memory leak
Date: Fri, 10 Jul 2015 08:51:27 +0800	[thread overview]
Message-ID: <1436489490-236-2-git-send-email-arei.gonglei@huawei.com> (raw)
In-Reply-To: <1436489490-236-1-git-send-email-arei.gonglei@huawei.com>

From: Gonglei <arei.gonglei@huawei.com>

Failing to save or free storage allocated
by "g_strdup(names[0])" leaks it. Actually,
we can pass names[0] directly.

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index f9b1788..1e49a14 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -3021,7 +3021,7 @@ static void x86_cpu_register_feature_bit_props(X86CPU *cpu,
 
     for (i = 1; names[i]; i++) {
         feat2prop(names[i]);
-        object_property_add_alias(obj, names[i], obj, g_strdup(names[0]),
+        object_property_add_alias(obj, names[i], obj, names[0],
                                   &error_abort);
     }
 
-- 
1.7.12.4

  reply	other threads:[~2015-07-10  0:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10  0:51 [Qemu-devel] [PATCH 0/4] fix memory leak arei.gonglei
2015-07-10  0:51 ` arei.gonglei [this message]
2015-07-10  0:51 ` [Qemu-devel] [PATCH 2/4] ppc/spapr_drc: " arei.gonglei
2015-07-10 18:49   ` [Qemu-devel] [Qemu-trivial] " Michael Roth
2015-07-10  0:51 ` [Qemu-devel] [PATCH 3/4] arm/xlnx-zynqmp: " arei.gonglei
2015-07-11  8:54   ` Peter Crosthwaite
2015-07-10  0:51 ` [Qemu-devel] [PATCH 4/4] vl.c: " arei.gonglei
2015-07-10  9:28   ` Leon Alrae
2015-07-10 10:39     ` Gonglei
2015-07-10 12:54 ` [Qemu-devel] [PATCH 0/4] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436489490-236-2-git-send-email-arei.gonglei@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).