From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDMXy-000322-EI for qemu-devel@nongnu.org; Thu, 09 Jul 2015 20:52:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDMXx-00051u-BM for qemu-devel@nongnu.org; Thu, 09 Jul 2015 20:52:10 -0400 From: Date: Fri, 10 Jul 2015 08:51:27 +0800 Message-ID: <1436489490-236-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1436489490-236-1-git-send-email-arei.gonglei@huawei.com> References: <1436489490-236-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 1/4] cpu: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Gonglei From: Gonglei Failing to save or free storage allocated by "g_strdup(names[0])" leaks it. Actually, we can pass names[0] directly. Signed-off-by: Gonglei --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f9b1788..1e49a14 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3021,7 +3021,7 @@ static void x86_cpu_register_feature_bit_props(X86CPU *cpu, for (i = 1; names[i]; i++) { feat2prop(names[i]); - object_property_add_alias(obj, names[i], obj, g_strdup(names[0]), + object_property_add_alias(obj, names[i], obj, names[0], &error_abort); } -- 1.7.12.4