From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDMXz-00033a-Dz for qemu-devel@nongnu.org; Thu, 09 Jul 2015 20:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDMXy-00052H-LW for qemu-devel@nongnu.org; Thu, 09 Jul 2015 20:52:11 -0400 From: Date: Fri, 10 Jul 2015 08:51:30 +0800 Message-ID: <1436489490-236-5-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1436489490-236-1-git-send-email-arei.gonglei@huawei.com> References: <1436489490-236-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 4/4] vl.c: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Gonglei From: Gonglei Failing to save or free storage allocated by "g_strdup(cmd)" leaks it. Let's use a variable to storage it. Signed-off-by: Gonglei --- vl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 3f269dc..399e816 100644 --- a/vl.c +++ b/vl.c @@ -1326,16 +1326,19 @@ static int add_semihosting_arg(void *opaque, static inline void semihosting_arg_fallback(const char *file, const char *cmd) { char *cmd_token; + char *cmd_str; /* argv[0] */ add_semihosting_arg(&semihosting, "arg", file, NULL); + cmd_str = g_strdup(cmd); /* split -append and initialize argv[1..n] */ - cmd_token = strtok(g_strdup(cmd), " "); + cmd_token = strtok(cmd_str, " "); while (cmd_token) { add_semihosting_arg(&semihosting, "arg", cmd_token, NULL); cmd_token = strtok(NULL, " "); } + g_free(cmd_str); } /***********************************************************/ -- 1.7.12.4