From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, hare@suse.de,
stefanha@redhat.com, pbonzini@redhat.com,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] ahci: fix atapi PIO (for 2.4?)
Date: Fri, 10 Jul 2015 21:05:08 -0400 [thread overview]
Message-ID: <1436576710-10414-1-git-send-email-jsnow@redhat.com> (raw)
ATAPI transfers using the AHCI HBA will work if you ask the HBA to perform
a DMA transfer, but if you ask for PIO, it will not.
All AHCI transfers are actually DMA anyway, but the AHCI HBA will need some
assistance from the core layer to help it manage its covert-ops DMA when
performing PIO routines deep in the bowels of the ATAPI code.
This is strictly a bugfix and /maybe/ it's 2.4-rc1 material, but the CDROM
tests for AHCI are not ready for prime-time (we don't have ANY cdrom tests
yet, really!) so I am submitting just the fix now, and my say-so that yes,
this fixes OVMF booting and pleases my hacky, off-list CDROM qtests.
________________________________________________________________________________
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch ahci-atapi-pio
https://github.com/jnsnow/qemu/tree/ahci-atapi-pio
This version is tagged ahci-atapi-pio-v1:
https://github.com/jnsnow/qemu/releases/tag/ahci-atapi-pio-v1
John Snow (2):
atapi: abort transfers with 0 byte limits
ide: unify io_buffer_offset increments
hw/ide/ahci.c | 22 +++++++---------------
hw/ide/atapi.c | 10 +++++++++-
hw/ide/core.c | 7 +++----
hw/ide/internal.h | 2 ++
4 files changed, 21 insertions(+), 20 deletions(-)
--
2.1.0
next reply other threads:[~2015-07-11 1:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 1:05 John Snow [this message]
2015-07-11 1:05 ` [Qemu-devel] [PATCH 1/2] atapi: abort transfers with 0 byte limits John Snow
2015-07-13 10:18 ` Kevin Wolf
2015-07-13 15:09 ` John Snow
2015-08-25 0:25 ` John Snow
2015-09-01 12:06 ` Kevin Wolf
2015-07-11 1:05 ` [Qemu-devel] [PATCH 2/2] ide: unify io_buffer_offset increments John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436576710-10414-1-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=hare@suse.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).