From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEYKs-0003Tn-84 for qemu-devel@nongnu.org; Mon, 13 Jul 2015 03:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEYKo-0003qX-5w for qemu-devel@nongnu.org; Mon, 13 Jul 2015 03:39:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEYKo-0003oc-0T for qemu-devel@nongnu.org; Mon, 13 Jul 2015 03:39:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 26356A10A8 for ; Mon, 13 Jul 2015 07:39:29 +0000 (UTC) From: Thomas Huth Date: Mon, 13 Jul 2015 09:39:21 +0200 Message-Id: <1436773166-12113-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/5] For QEMU 2.5: Network traffic dumping for -netdev devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi , Jason Wang Cc: Markus Armbruster The "-net dump" option only works with the "-net" option. So far, it is not possible to dump network traffic with the "-netdev" option yet. This patch series now fixes this ugliness by enabling dumping for the "-netdev" option, too. Unlike with the "-net dump" option, the "-netdev" parameter does not "abuse" the disliked internal vlan hub infrastructure to achieve this functionality. This patch series introduces a new, clean "dumpfile=xxx" option for the -netdev parameters instead. The patches are intended for QEMU version 2.5, but I'm sending them now already in case somebody got some spare minutes left for reviewing them again. Note: I did not address multiqueue devices yet (but added a TODO in the source code) ... I will address that later when the basic patches have been accepted. v2: - Restructured the code a little bit - Updated target QEMU version from 2.4. to 2.5 - Addressed review feedback from Jason, Stefan and Markus: - Use iov_copy() instead of copying the iov manually - Fix return value of net_dump_receive_iov() if fd is invalid - Use get_vhost_net() to detect vhost devices - Close the fd when netdev is deleted - Added some more comments in the source code Thomas Huth (5): net/dump: Add support for receive_iov function net/dump: Move DumpState into NetClientState net/dump: Rework net-dump init functions net/dump: Add dump option for netdev devices qemu options: Add information about dumpfile to help text include/net/net.h | 8 +++++ net/clients.h | 6 ++++ net/dump.c | 99 +++++++++++++++++++++++++++++++++++++++---------------- net/net.c | 38 ++++++++++++++++++++- qapi-schema.json | 12 +++++-- qemu-options.hx | 26 ++++++++++----- 6 files changed, 149 insertions(+), 40 deletions(-) -- 1.8.3.1