From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts
Date: Mon, 13 Jul 2015 14:01:40 +0200 [thread overview]
Message-ID: <1436788900.26533.25.camel@redhat.com> (raw)
In-Reply-To: <1436788098.26533.22.camel@redhat.com>
On Mo, 2015-07-13 at 13:48 +0200, Gerd Hoffmann wrote:
> On Mo, 2015-07-13 at 09:56 +0100, Peter Maydell wrote:
> > On 13 July 2015 at 08:30, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > > As we include a copy of the linux input layer header file in the qemu
> > > source tree (include/standard-headers/linux/input.h) the virtio-input
> > > bits (except pass-through) should build and work just fine on non-linux
> > > hosts too. Tweak Makefile accordingly.
> >
> > Does "should" here mean "I haven't actually tested it" ? :-)
>
> Did a build test on freebsd -- passed.
Oops, the windows cross builds fails though (due to
include/standard-headers/linux/input.h including sys/ioctl.h).
Ok, scratch that one, back to the drawing board ...
sorry,
Gerd
next prev parent reply other threads:[~2015-07-13 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 7:30 [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts Gerd Hoffmann
2015-07-13 8:56 ` Peter Maydell
2015-07-13 11:48 ` Gerd Hoffmann
2015-07-13 12:01 ` Gerd Hoffmann [this message]
2015-07-13 12:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436788900.26533.25.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).