From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFLNP-0004bE-HS for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFLNJ-0005aV-HI for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:01:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFLNJ-0005aN-CW for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:01:21 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id F1F26CA630 for ; Wed, 15 Jul 2015 12:01:20 +0000 (UTC) Message-ID: <1436961678.8987.3.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 15 Jul 2015 14:01:18 +0200 In-Reply-To: <55A63FA6.5090907@redhat.com> References: <1436955007-8216-1-git-send-email-kraxel@redhat.com> <1436955007-8216-8-git-send-email-kraxel@redhat.com> <55A63FA6.5090907@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] ipxe: update binaries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org On Mi, 2015-07-15 at 13:10 +0200, Laszlo Ersek wrote: > On 07/15/15 12:10, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > pc-bios/efi-e1000.rom | Bin 197120 -> 192512 bytes > > pc-bios/efi-eepro100.rom | Bin 197632 -> 192512 bytes > > pc-bios/efi-ne2k_pci.rom | Bin 195584 -> 190976 bytes > > pc-bios/efi-pcnet.rom | Bin 195584 -> 190976 bytes > > pc-bios/efi-rtl8139.rom | Bin 200192 -> 194560 bytes > > pc-bios/efi-virtio.rom | Bin 194048 -> 188928 bytes > > 6 files changed, 0 insertions(+), 0 deletions(-) > > Shouldn't you also rebuild (well, commit) the non-EFI (ie. pxe-*) > binaries too? The rebase in patch #1, the QEMU branding in patch #5, and > the now-visible git version from patch #6, all seem to affect the pxe-* > binaries as well. We didn't do that in the past, because of size problems and because the pxe-* versions are only used by old machine types. Lets have a look: pc-bios/pxe-e1000.rom | Bin 67072 -> 62976 bytes pc-bios/pxe-eepro100.rom | Bin 61440 -> 62976 bytes pc-bios/pxe-ne2k_pci.rom | Bin 61440 -> 62464 bytes pc-bios/pxe-pcnet.rom | Bin 61440 -> 62464 bytes pc-bios/pxe-rtl8139.rom | Bin 61440 -> 63488 bytes pc-bios/pxe-virtio.rom | Bin 60416 -> 61952 bytes So, the update doesn't work for e1000, where the size goes from > 64k to < 64k, which in turn changes the pci rom bar size from 128k to 64k ... cheers, Gerd