From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFSsg-0004JV-W7 for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFSsc-0000KO-Te for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFSsc-0000KJ-P8 for qemu-devel@nongnu.org; Wed, 15 Jul 2015 16:02:10 -0400 From: Eduardo Habkost Date: Wed, 15 Jul 2015 17:02:02 -0300 Message-Id: <1436990522-22700-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1436990522-22700-1-git-send-email-ehabkost@redhat.com> References: <1436990522-22700-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 1/1] numa: Fix memory leak in numa_set_mem_node_id() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Bharata B Rao From: Bharata B Rao Fix a memory leak in numa_set_mem_node_id(). Signed-off-by: Bharata B Rao Reported-by: Paolo Bonzini Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- numa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index 3c80059..402804b 100644 --- a/numa.c +++ b/numa.c @@ -54,7 +54,7 @@ NodeInfo numa_info[MAX_NODES]; void numa_set_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node) { - struct numa_addr_range *range = g_malloc0(sizeof(*range)); + struct numa_addr_range *range; /* * Memory-less nodes can come here with 0 size in which case, @@ -64,6 +64,7 @@ void numa_set_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node) return; } + range = g_malloc0(sizeof(*range)); range->mem_start = addr; range->mem_end = addr + size - 1; QLIST_INSERT_HEAD(&numa_info[node].addr, range, entry); -- 2.1.0