From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] 9pfs: restrict open to regular files and directories
Date: Tue, 10 Jan 2017 08:41:23 -0600 [thread overview]
Message-ID: <1436b9db-dea9-cfa4-65f8-bd1455394e6f@redhat.com> (raw)
In-Reply-To: <b227e7dc-ba0b-7da7-8fdb-dece1cbe51d4@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On 01/10/2017 08:38 AM, Eric Blake wrote:
> I think you need to rework this patch to open() first, then validate
> (closing the fd if necessary); the open can be done with O_NONBLOCK to
> avoid hanging on a pipe.
And O_NOCTTY to avoid becoming the controlling process of a terminal.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-10 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:32 [Qemu-devel] [PATCH 0/7] fix potential hangs in 9pfs Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 1/7] 9pfs: restrict open to regular files and directories Greg Kurz
2017-01-10 14:38 ` Eric Blake
2017-01-10 14:41 ` Eric Blake [this message]
2017-01-11 9:54 ` Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 2/7] tests: virtio-9p: improve error reporting Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 3/7] tests: virtio-9p: add LOPEN operation test Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 4/7] tests: virtio-9p: TLOPEN should fail to open a FIFO Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 5/7] 9pfs: don't create files if pathname already exists Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 6/7] tests: virtio-9p: add LCREATE operation test Greg Kurz
2017-01-10 14:32 ` [Qemu-devel] [PATCH 7/7] tests: virtio-9p: TLCREATE should fail if pathname exists Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436b9db-dea9-cfa4-65f8-bd1455394e6f@redhat.com \
--to=eblake@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).