From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFaoi-0005EH-M0 for qemu-devel@nongnu.org; Thu, 16 Jul 2015 00:30:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFaod-0006Pf-QV for qemu-devel@nongnu.org; Thu, 16 Jul 2015 00:30:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFaod-0006PX-LI for qemu-devel@nongnu.org; Thu, 16 Jul 2015 00:30:35 -0400 Message-ID: <1437020496.1391.549.camel@redhat.com> From: Alex Williamson Date: Wed, 15 Jul 2015 22:21:36 -0600 In-Reply-To: <1437019253-17630-1-git-send-email-chenhanxiao@cn.fujitsu.com> References: <1437019253-17630-1-git-send-email-chenhanxiao@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 00/15] vfio-pci: pass the aer error to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Hanxiao Cc: Chen Fan , qemu-devel@nongnu.org On Thu, 2015-07-16 at 12:00 +0800, Chen Hanxiao wrote: > From: Chen Fan > > For now, when qemu receives an error from host aer report > by vfio pci passthough devices, qemu just terminate the guest. > Usually user want to know what error occurred > rather than stop the guest. > > This patches add aer capability support for vfio device, > then pass the error to guest, and let guest driver to recover > from the error. > Turning on SERR# for error forwording in bridge control register > patch in seabios has been merged as commit 32ec3ee. > > notes: > this series patches enable aer support single/multi-function, > for multi-function, require all the function of the slot assigned to > VM and on the same slot. > > Chen Fan (15): > vfio: extract vfio_get_hot_reset_info as a single function > vfio: squeeze out vfio_pci_do_hot_reset for support bus reset > pcie: modify the capability size assert > vfio: make the 4 bytes aligned for capability size > vfio: add pcie extanded capability support > aer: impove pcie_aer_init to support vfio device > vfio: add aer support for vfio device > vfio: add check host bus reset is support or not > pci: add bus reset_notifiers callbacks for host bus reset > vfio: add sec_bus_reset notifier to notify physical bus reset is > needed > vfio: modify vfio_pci_hot_reset to support bus reset > vfio: do hot bus reset when do virtual secondary bus reset > pcie_aer: expose pcie_aer_msg() interface > vfio-pci: pass the aer error to guest > vfio: add 'aer' property to expose aercap > > hw/pci-bridge/ioh3420.c | 2 +- > hw/pci-bridge/xio3130_downstream.c | 2 +- > hw/pci-bridge/xio3130_upstream.c | 2 +- > hw/pci/pci.c | 16 + > hw/pci/pci_bridge.c | 6 + > hw/pci/pcie.c | 2 +- > hw/pci/pcie_aer.c | 6 +- > hw/vfio/pci.c | 636 +++++++++++++++++++++++++++++++++---- > include/hw/pci/pci.h | 4 + > include/hw/pci/pci_bus.h | 2 + > include/hw/pci/pcie_aer.h | 3 +- > 11 files changed, 609 insertions(+), 72 deletions(-) This seems to be pretty much the same as v11 where I commented that I didn't think it was acceptable to have a feature dependent on having all the functions assigned without supporting hot-add of multi-function devices. Can you summarize what's changed here and whether that comment was addressed. It would be a courtesy to reviewers to provide at least a summary changelog with each new version. Thanks, Alex