From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFfur-0005xM-Rb for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFfuo-00052R-Lu for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:57:21 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:36383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFfuo-00051t-Eq for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:57:18 -0400 Received: by widjy10 with SMTP id jy10so10933280wid.1 for ; Thu, 16 Jul 2015 02:57:17 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 16 Jul 2015 11:56:46 +0200 Message-Id: <1437040609-9878-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, lersek@redhat.com, rjones@redhat.com, stefanha@redhat.com Apart from an additional assertion this is exactly the same code as v1, but split across three patches so that the important one focuses on the optimization. Paolo v1->v2 Split some changes to the tests to a separate patch Fix commit message [Laszlo] Clarify do...while loop in aio-win32.c [Kevin] Paolo Bonzini (3): tests: remove irrelevant assertions from test-aio aio-win32: reorganize polling loop AioContext: fix broken ctx->dispatching optimization aio-posix.c | 19 ++++++------ aio-win32.c | 41 ++++++++++++++------------ async.c | 21 +++++--------- docs/aio_notify.promela | 77 +++++++++++++++++++++---------------------------- include/block/aio.h | 29 +++++++++++++++---- tests/test-aio.c | 26 +++-------------- 6 files changed, 98 insertions(+), 115 deletions(-) -- 2.4.3 diff from v1: diff --git a/aio-win32.c b/aio-win32.c index ae7c6cf..9d6c12f 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -312,7 +312,13 @@ bool aio_poll(AioContext *ctx, bool blocking) ctx->walking_handlers--; first = true; - /* wait until next event */ + /* ctx->notifier is always registered. */ + assert(count > 0); + + /* Multiple iterations, all of them non-blocking except the first, + * may be necessary to process all pending events. After the first + * WaitForMultipleObjects call ctx->notify_me will be decremented. + */ do { HANDLE event; int ret;