qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4
Date: Fri, 17 Jul 2015 08:52:37 +0200	[thread overview]
Message-ID: <1437115957.3689.4.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA8VME-7nzpJLEOCk0brcVZvjv5xTt+wUPUvqof9uPnwFQ@mail.gmail.com>

  Hi,

> I'm afraid this doesn't build for Windows:
> 
> In file included from
> /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:13:
> /home/petmay01/linaro/qemu-for-merges/include/standard-headers/linux/input.h:890:1:
> error: "SW_MAX" redefined
> In file included from
> /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/windows.h:55,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:29,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/qemu-common.h:48,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/qemu/iov.h:17,
>                  from
> /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:7:
> /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/winuser.h:729:1:
> error: this is the location of the previous definition

Lovely.  Looks like a bug in the mingw headers to me, especially as my
machine cross-builds this just fine for both win32 and win64.

We are in hard-freeze though, so no time to experiments here, I'll redo
the pull with patch #3 dropped, lets sort this post-2.4.

cheers,
  Gerd

      reply	other threads:[~2015-07-17  6:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 15:38 [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4 Gerd Hoffmann
2015-07-16 15:38 ` [Qemu-devel] [PULL 1/4] virtio-input: fix segfault in virtio_input_hid_properties Gerd Hoffmann
2015-07-16 15:38 ` [Qemu-devel] [PULL 2/4] virtio-input: move sys/ioctl.h include Gerd Hoffmann
2015-07-16 15:38 ` [Qemu-devel] [PULL 3/4] virtio-input: enable on non-linux hosts Gerd Hoffmann
2015-07-16 15:38 ` [Qemu-devel] [PULL 4/4] hid: clarify hid_keyboard_process_keycode Gerd Hoffmann
2015-07-16 17:34 ` [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4 Peter Maydell
2015-07-17  6:52   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437115957.3689.4.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).