From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZFzVm-0001tU-CP
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:52:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZFzVh-00030A-Cp
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:52:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZFzVh-000304-6n
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:52:41 -0400
Message-ID: <1437115957.3689.4.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 17 Jul 2015 08:52:37 +0200
In-Reply-To: <CAFEAcA8VME-7nzpJLEOCk0brcVZvjv5xTt+wUPUvqof9uPnwFQ@mail.gmail.com>
References: <1437061085-9370-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA8VME-7nzpJLEOCk0brcVZvjv5xTt+wUPUvqof9uPnwFQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

  Hi,

> I'm afraid this doesn't build for Windows:
> 
> In file included from
> /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:13:
> /home/petmay01/linaro/qemu-for-merges/include/standard-headers/linux/input.h:890:1:
> error: "SW_MAX" redefined
> In file included from
> /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/windows.h:55,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:29,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/qemu-common.h:48,
>                  from
> /home/petmay01/linaro/qemu-for-merges/include/qemu/iov.h:17,
>                  from
> /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:7:
> /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/winuser.h:729:1:
> error: this is the location of the previous definition

Lovely.  Looks like a bug in the mingw headers to me, especially as my
machine cross-builds this just fine for both win32 and win64.

We are in hard-freeze though, so no time to experiments here, I'll redo
the pull with patch #3 dropped, lets sort this post-2.4.

cheers,
  Gerd