qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: [Qemu-devel] [PATCH qemu] vfio_pci: Allow disabling quirks
Date: Sun, 19 Jul 2015 18:19:30 +1000	[thread overview]
Message-ID: <1437293970-6727-1-git-send-email-aik@ozlabs.ru> (raw)

The existing quirks aim config space and MSIX BAR accesses interception.
These are not always needed, for example, on pseries machines,
config space and MSI/MSIX configuration are handled by hypervisor.

This adds a "quirks" property to control whether to enable quirks or not;
the property is set to "true" by default.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---

Helps to get
VGA compatible controller: NVIDIA Corporation GM107GL [Quadro K2200] (rev a2)
(which does not need the quirk anyway) working on POWER8 system.
---
 hw/vfio/pci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 2ed877f..ba47301 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -168,6 +168,7 @@ typedef struct VFIOPCIDevice {
     bool has_flr;
     bool has_pm_reset;
     bool rom_read_failed;
+    bool allow_quirks;
 } VFIOPCIDevice;
 
 typedef struct VFIORomBlacklistEntry {
@@ -2442,7 +2443,9 @@ static void vfio_map_bar(VFIOPCIDevice *vdev, int nr)
         }
     }
 
-    vfio_bar_quirk_setup(vdev, nr);
+    if (vdev->allow_quirks) {
+        vfio_bar_quirk_setup(vdev, nr);
+    }
 }
 
 static void vfio_map_bars(VFIOPCIDevice *vdev)
@@ -3753,6 +3756,7 @@ static Property vfio_pci_dev_properties[] = {
                     VFIO_FEATURE_ENABLE_REQ_BIT, true),
     DEFINE_PROP_INT32("bootindex", VFIOPCIDevice, bootindex, -1),
     DEFINE_PROP_BOOL("x-mmap", VFIOPCIDevice, vbasedev.allow_mmap, true),
+    DEFINE_PROP_BOOL("quirks", VFIOPCIDevice, allow_quirks, true),
     /*
      * TODO - support passed fds... is this necessary?
      * DEFINE_PROP_STRING("vfiofd", VFIOPCIDevice, vfiofd_name),
-- 
2.4.0.rc3.8.gfb3e7d5

             reply	other threads:[~2015-07-19  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19  8:19 Alexey Kardashevskiy [this message]
2015-07-19 12:50 ` [Qemu-devel] [PATCH qemu] vfio_pci: Allow disabling quirks Alex Williamson
2015-07-19 17:15   ` Alex Williamson
2015-07-20  2:40     ` Alexey Kardashevskiy
2015-09-09  7:17       ` Alexey Kardashevskiy
2015-09-09 18:34         ` Alex Williamson
2015-10-02  7:58           ` Alexey Kardashevskiy
2015-10-02 14:20             ` Alex Williamson
2015-10-03 10:15               ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437293970-6727-1-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).