* [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library
@ 2015-07-20 8:43 Frediano Ziglio
2015-07-20 8:51 ` Christophe Fergeau
2015-07-20 9:46 ` [Qemu-devel] [libvirt] " Martin Kletzander
0 siblings, 2 replies; 4+ messages in thread
From: Frediano Ziglio @ 2015-07-20 8:43 UTC (permalink / raw)
To: qemu-devel, kraxel, peter.maydell, pgrunt, cfergeau
Cc: libvir-list, spice-devel, pkrempa, Frediano Ziglio
The new spice-server function to limit the number of monitors (0.12.6)
changed while development from spice_qxl_set_monitors_config_limit to
spice_qxl_max_monitors (accepted upstream).
By mistake I post patch with former name.
This patch fix the function name.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
hw/display/qxl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
I tested again doing a clean build, unfortunately I did some mistake
and my tests worked.
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 4e5ff69..2288238 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -273,8 +273,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
} else {
#if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */
if (qxl->max_outputs) {
- spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl,
- qxl->max_outputs);
+ spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
}
#endif
qxl->guest_monitors_config = qxl->ram->monitors_config;
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library
2015-07-20 8:43 [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library Frediano Ziglio
@ 2015-07-20 8:51 ` Christophe Fergeau
2015-07-20 9:46 ` [Qemu-devel] [libvirt] " Martin Kletzander
1 sibling, 0 replies; 4+ messages in thread
From: Christophe Fergeau @ 2015-07-20 8:51 UTC (permalink / raw)
To: Frediano Ziglio
Cc: peter.maydell, pkrempa, libvir-list, qemu-devel, pgrunt, kraxel,
spice-devel
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
> The new spice-server function to limit the number of monitors (0.12.6)
> changed while development from spice_qxl_set_monitors_config_limit to
> spice_qxl_max_monitors (accepted upstream).
> By mistake I post patch with former name.
> This patch fix the function name.
>
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
>
> ---
> hw/display/qxl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> I tested again doing a clean build, unfortunately I did some mistake
> and my tests worked.
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 4e5ff69..2288238 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -273,8 +273,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
> } else {
> #if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */
> if (qxl->max_outputs) {
> - spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl,
> - qxl->max_outputs);
> + spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
> }
> #endif
> qxl->guest_monitors_config = qxl->ram->monitors_config;
ACK from me,
Christophe
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [libvirt] [PATCH] qxl: Fix new function name for spice-server library
2015-07-20 8:43 [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library Frediano Ziglio
2015-07-20 8:51 ` Christophe Fergeau
@ 2015-07-20 9:46 ` Martin Kletzander
2015-07-22 14:37 ` [Qemu-devel] [Spice-devel] " Marc-André Lureau
1 sibling, 1 reply; 4+ messages in thread
From: Martin Kletzander @ 2015-07-20 9:46 UTC (permalink / raw)
To: Frediano Ziglio
Cc: peter.maydell, pkrempa, libvir-list, qemu-devel, cfergeau, pgrunt,
kraxel, spice-devel
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
>The new spice-server function to limit the number of monitors (0.12.6)
>changed while development from spice_qxl_set_monitors_config_limit to
>spice_qxl_max_monitors (accepted upstream).
>By mistake I post patch with former name.
>This patch fix the function name.
>
>Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
>
>---
> hw/display/qxl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>I tested again doing a clean build, unfortunately I did some mistake
>and my tests worked.
>
>diff --git a/hw/display/qxl.c b/hw/display/qxl.c
>index 4e5ff69..2288238 100644
>--- a/hw/display/qxl.c
>+++ b/hw/display/qxl.c
>@@ -273,8 +273,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
> } else {
> #if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */
> if (qxl->max_outputs) {
>- spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl,
>- qxl->max_outputs);
>+ spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
> }
> #endif
> qxl->guest_monitors_config = qxl->ram->monitors_config;
>--
>2.1.0
>
Same as the fix I did in order for this to work with upstream spice.
ACK. Weak, though, as I'm not a privileged one.
Martin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Spice-devel] [libvirt] [PATCH] qxl: Fix new function name for spice-server library
2015-07-20 9:46 ` [Qemu-devel] [libvirt] " Martin Kletzander
@ 2015-07-22 14:37 ` Marc-André Lureau
0 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2015-07-22 14:37 UTC (permalink / raw)
To: Martin Kletzander
Cc: Peter Maydell, Peter Krempa, QEMU, Christophe Fergeau,
Gerd Hoffmann, spice-devel, Frediano Ziglio
Hi
On Mon, Jul 20, 2015 at 11:46 AM, Martin Kletzander <mkletzan@redhat.com> wrote:
> On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
>>
>> The new spice-server function to limit the number of monitors (0.12.6)
>> changed while development from spice_qxl_set_monitors_config_limit to
>> spice_qxl_max_monitors (accepted upstream).
>> By mistake I post patch with former name.
>> This patch fix the function name.
>>
>> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
>>
ACK, I'll try sending a proper pull request for 2.4 since Gerd is on holidays
>> ---
>> hw/display/qxl.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> I tested again doing a clean build, unfortunately I did some mistake
>> and my tests worked.
>>
>> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
>> index 4e5ff69..2288238 100644
>> --- a/hw/display/qxl.c
>> +++ b/hw/display/qxl.c
>> @@ -273,8 +273,7 @@ static void
>> qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
>> } else {
>> #if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */
>> if (qxl->max_outputs) {
>> - spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl,
>> - qxl->max_outputs);
>> + spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
>> }
>> #endif
>> qxl->guest_monitors_config = qxl->ram->monitors_config;
>> --
>> 2.1.0
H>>
>
> Same as the fix I did in order for this to work with upstream spice.
>
> ACK. Weak, though, as I'm not a privileged one.
>
> Martin
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-22 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 8:43 [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library Frediano Ziglio
2015-07-20 8:51 ` Christophe Fergeau
2015-07-20 9:46 ` [Qemu-devel] [libvirt] " Martin Kletzander
2015-07-22 14:37 ` [Qemu-devel] [Spice-devel] " Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).