[Qemu-devel] [PATCH 1/1] qga: fixed versions for guest bus types in qapi-schema

[Qemu-devel] [PATCH 1/1] qga: fixed versions for guest bus types in qapi-schema

[Denis V. Lunev]

From: Olga Krishtal <okrishtal@parallels.com>

Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Eric Blake <eblake@redhat.com>
CC: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/qapi-schema.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 8a9b818..b81b212 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -714,7 +714,7 @@
 # @virtual: Win virtual bus type
 # @file-backed virtual: Win file-backed bus type
 #
-# Since: 2.2
+# Since: 2.2 'Unknown' and all entries below since 2.4
 ##
 { 'enum': 'GuestDiskBusType',
   'data': [ 'ide', 'fdc', 'scsi', 'virtio', 'xen', 'usb', 'uml', 'sata',
-- 
2.1.4

Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest bus types in qapi-schema

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On 07/21/2015 06:25 AM, Denis V. Lunev wrote:
> From: Olga Krishtal <okrishtal@parallels.com>
> 
> Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>

doc-only, so I've added 2.4 to the subject line.

> ---
>  qga/qapi-schema.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8a9b818..b81b212 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -714,7 +714,7 @@
>  # @virtual: Win virtual bus type
>  # @file-backed virtual: Win file-backed bus type
>  #
> -# Since: 2.2
> +# Since: 2.2 'Unknown' and all entries below since 2.4

I would have put a comma or semicolon there for legibility:

Since: 2.2; 'Unknown' and ...

but it's minor enough that a maintainer could touch it up, or even live
with it as is, without needing a v2.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH 1/1] qga: fixed versions for guest bus types in qapi-schema

[Michael Roth]

Quoting Denis V. Lunev (2015-07-21 07:25:08)
> From: Olga Krishtal <okrishtal@parallels.com>
> 
> Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>

Thanks, applied with Eric's suggested fix-up squashed in:

  https://github.com/mdroth/qemu/commits/qga

> ---
>  qga/qapi-schema.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8a9b818..b81b212 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -714,7 +714,7 @@
>  # @virtual: Win virtual bus type
>  # @file-backed virtual: Win file-backed bus type
>  #
> -# Since: 2.2
> +# Since: 2.2 'Unknown' and all entries below since 2.4
>  ##
>  { 'enum': 'GuestDiskBusType',
>    'data': [ 'ide', 'fdc', 'scsi', 'virtio', 'xen', 'usb', 'uml', 'sata',
> -- 
> 2.1.4
>