From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, lersek@redhat.com,
rjones@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v4 1/6] qemu-timer: initialize "timers_done_ev" to set
Date: Tue, 21 Jul 2015 16:07:48 +0200 [thread overview]
Message-ID: <1437487673-23740-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1437487673-23740-1-git-send-email-pbonzini@redhat.com>
The normal value for the event is to be set. If we do not do
this, pause_all_vcpus (through qemu_clock_enable) hangs unless
timerlist_run_timers has been run at least once for the timerlist.
This can happen with the following patches, that make aio_notify do
nothing most of the time.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qemu-timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index aa6757e..2463fe6 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -99,7 +99,7 @@ QEMUTimerList *timerlist_new(QEMUClockType type,
QEMUClock *clock = qemu_clock_ptr(type);
timer_list = g_malloc0(sizeof(QEMUTimerList));
- qemu_event_init(&timer_list->timers_done_ev, false);
+ qemu_event_init(&timer_list->timers_done_ev, true);
timer_list->clock = clock;
timer_list->notify_cb = cb;
timer_list->notify_opaque = opaque;
--
2.4.3
next prev parent reply other threads:[~2015-07-21 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 14:07 [Qemu-devel] [PATCH v4 0/6] AioContext: ctx->dispatching is dead, all hail ctx->notify_me Paolo Bonzini
2015-07-21 14:07 ` Paolo Bonzini [this message]
2015-07-21 14:07 ` [Qemu-devel] [PATCH v4 2/6] tests: remove irrelevant assertions from test-aio Paolo Bonzini
2015-07-21 14:07 ` [Qemu-devel] [PATCH v4 3/6] aio-win32: reorganize polling loop Paolo Bonzini
2015-07-21 14:07 ` [Qemu-devel] [PATCH v4 4/6] AioContext: fix broken ctx->dispatching optimization Paolo Bonzini
2015-07-21 14:07 ` [Qemu-devel] [PATCH v4 5/6] AioContext: fix broken placement of event_notifier_test_and_clear Paolo Bonzini
2015-07-21 14:07 ` [Qemu-devel] [PATCH v4 6/6] AioContext: optimize clearing the EventNotifier Paolo Bonzini
2015-07-22 2:23 ` [Qemu-devel] [PATCH v4 0/6] AioContext: ctx->dispatching is dead, all hail ctx->notify_me Fam Zheng
2015-07-22 9:41 ` Richard W.M. Jones
2015-07-22 11:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437487673-23740-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).