From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHYDe-0001ph-Pu for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHYDc-0006Jx-T4 for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:08:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHYDc-0006Jm-NL for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:08:28 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7642336B39B for ; Tue, 21 Jul 2015 14:08:28 +0000 (UTC) From: Paolo Bonzini Date: Tue, 21 Jul 2015 16:07:48 +0200 Message-Id: <1437487673-23740-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1437487673-23740-1-git-send-email-pbonzini@redhat.com> References: <1437487673-23740-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v4 1/6] qemu-timer: initialize "timers_done_ev" to set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, lersek@redhat.com, rjones@redhat.com, stefanha@redhat.com The normal value for the event is to be set. If we do not do this, pause_all_vcpus (through qemu_clock_enable) hangs unless timerlist_run_timers has been run at least once for the timerlist. This can happen with the following patches, that make aio_notify do nothing most of the time. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c index aa6757e..2463fe6 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -99,7 +99,7 @@ QEMUTimerList *timerlist_new(QEMUClockType type, QEMUClock *clock = qemu_clock_ptr(type); timer_list = g_malloc0(sizeof(QEMUTimerList)); - qemu_event_init(&timer_list->timers_done_ev, false); + qemu_event_init(&timer_list->timers_done_ev, true); timer_list->clock = clock; timer_list->notify_cb = cb; timer_list->notify_opaque = opaque; -- 2.4.3