qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com,
	Jason Wang <jasowang@redhat.com>,
	mst@redhat.com
Subject: [Qemu-devel] [PATCH V3 0/3] Set correct blk feature for virtio 1.0
Date: Wed, 22 Jul 2015 13:59:49 +0800	[thread overview]
Message-ID: <1437544792-3949-1-git-send-email-jasowang@redhat.com> (raw)

Hi all:

This series tries to set feature correctly for virtio-blk when virtio
1.0 is supported. Two isssues were addressed according to the spec:

- scsi passthrough was not support in 1.0. This is done through: 1)
  let get_features() can fail 2) fail the get_features() when both
  scsi and virtio 1.0 is enabled.
- any layout must be set for transitional device. This is done by set
  any layout when 1.0 is supported.

Changes from V2:
- Keep scsi=on by default since virtio 1.0 is disabled by default
- Advertise VIRTIO_BLK_F_SCSI unconditionally if virtio 1.0 is
  disabled

Changes from V1:
- Split virtio-net changes out of the series
- Enable VIRTIO_BLK_F_SCSI only when scsi is set
- Disable scsi by default and compat it for legacy machine types
- Let get_features() can fail and fail the initialization of
  virito-blk when both 1.0 and scsi were supported.

Jason Wang (3):
  virtio: get_features() can fail
  virtio-blk: fail get_features when both scsi and 1.0 were set
  virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported

 hw/9pfs/virtio-9p-device.c  |  3 ++-
 hw/block/virtio-blk.c       | 13 +++++++++++--
 hw/char/virtio-serial-bus.c |  3 ++-
 hw/display/virtio-gpu.c     |  3 ++-
 hw/input/virtio-input.c     |  3 ++-
 hw/net/virtio-net.c         |  3 ++-
 hw/scsi/vhost-scsi.c        |  3 ++-
 hw/scsi/virtio-scsi.c       |  3 ++-
 hw/virtio/virtio-balloon.c  |  3 ++-
 hw/virtio/virtio-bus.c      |  3 ++-
 hw/virtio/virtio-rng.c      |  2 +-
 include/hw/virtio/virtio.h  |  4 +++-
 12 files changed, 33 insertions(+), 13 deletions(-)

-- 
2.1.4

             reply	other threads:[~2015-07-22  6:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22  5:59 Jason Wang [this message]
2015-07-22  5:59 ` [Qemu-devel] [PATCH V3 1/3] virtio: get_features() can fail Jason Wang
2015-07-22  5:59 ` [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set Jason Wang
2015-07-22  8:58   ` Cornelia Huck
2015-07-22  9:21     ` Michael S. Tsirkin
2015-07-22 10:25       ` Cornelia Huck
2015-07-22 10:32         ` Michael S. Tsirkin
2015-07-22 10:38           ` Cornelia Huck
2015-07-22 10:44             ` Michael S. Tsirkin
2015-07-22 10:55               ` Cornelia Huck
2015-07-22 14:53                 ` Michael S. Tsirkin
2015-07-22 16:11                   ` Cornelia Huck
2015-07-22 16:34                     ` Michael S. Tsirkin
2015-07-23  9:07                       ` Cornelia Huck
2015-07-23  9:37                         ` Paolo Bonzini
2015-07-23 10:15                           ` Cornelia Huck
2015-07-22  9:35     ` Jason Wang
2015-07-22 10:23       ` Cornelia Huck
2015-07-22  9:25   ` Michael S. Tsirkin
2015-07-22  9:52     ` Jason Wang
2015-07-22 10:12       ` Michael S. Tsirkin
2015-07-22 10:13         ` Michael S. Tsirkin
2015-07-22  9:31   ` Daniel P. Berrange
2015-07-22  9:45     ` Jason Wang
2015-07-22 10:19     ` Michael S. Tsirkin
2015-07-22 11:40       ` Paolo Bonzini
2015-07-22 11:46         ` Daniel P. Berrange
2015-07-22 11:53           ` Paolo Bonzini
2015-07-22 14:56             ` Michael S. Tsirkin
2015-07-22 16:15         ` Michael S. Tsirkin
2015-07-22 16:42           ` Paolo Bonzini
2015-07-22  5:59 ` [Qemu-devel] [PATCH V3 3/3] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437544792-3949-1-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).