From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, mst@redhat.com,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
cornelia.huck@de.ibm.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH V3 3/3] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported
Date: Wed, 22 Jul 2015 13:59:52 +0800 [thread overview]
Message-ID: <1437544792-3949-4-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1437544792-3949-1-git-send-email-jasowang@redhat.com>
Chapter 6.3 of spec said
"
Transitional devices MUST offer, and if offered by the device
transitional drivers MUST accept the following:
VIRTIO_F_ANY_LAYOUT (27)
"
So this patch sets VIRTIO_F_ANY_LAYOUT when 1.0 is supported.
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 4716c3e..2e7a190 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -736,6 +736,7 @@ static uint64_t virtio_blk_get_features(VirtIODevice *vdev, uint64_t features,
error_setg(errp, "Virtio 1.0 does not support scsi passthrough!");
return 0;
}
+ virtio_add_feature(&features, VIRTIO_F_ANY_LAYOUT);
} else {
virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
}
--
2.1.4
prev parent reply other threads:[~2015-07-22 6:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 5:59 [Qemu-devel] [PATCH V3 0/3] Set correct blk feature for virtio 1.0 Jason Wang
2015-07-22 5:59 ` [Qemu-devel] [PATCH V3 1/3] virtio: get_features() can fail Jason Wang
2015-07-22 5:59 ` [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set Jason Wang
2015-07-22 8:58 ` Cornelia Huck
2015-07-22 9:21 ` Michael S. Tsirkin
2015-07-22 10:25 ` Cornelia Huck
2015-07-22 10:32 ` Michael S. Tsirkin
2015-07-22 10:38 ` Cornelia Huck
2015-07-22 10:44 ` Michael S. Tsirkin
2015-07-22 10:55 ` Cornelia Huck
2015-07-22 14:53 ` Michael S. Tsirkin
2015-07-22 16:11 ` Cornelia Huck
2015-07-22 16:34 ` Michael S. Tsirkin
2015-07-23 9:07 ` Cornelia Huck
2015-07-23 9:37 ` Paolo Bonzini
2015-07-23 10:15 ` Cornelia Huck
2015-07-22 9:35 ` Jason Wang
2015-07-22 10:23 ` Cornelia Huck
2015-07-22 9:25 ` Michael S. Tsirkin
2015-07-22 9:52 ` Jason Wang
2015-07-22 10:12 ` Michael S. Tsirkin
2015-07-22 10:13 ` Michael S. Tsirkin
2015-07-22 9:31 ` Daniel P. Berrange
2015-07-22 9:45 ` Jason Wang
2015-07-22 10:19 ` Michael S. Tsirkin
2015-07-22 11:40 ` Paolo Bonzini
2015-07-22 11:46 ` Daniel P. Berrange
2015-07-22 11:53 ` Paolo Bonzini
2015-07-22 14:56 ` Michael S. Tsirkin
2015-07-22 16:15 ` Michael S. Tsirkin
2015-07-22 16:42 ` Paolo Bonzini
2015-07-22 5:59 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437544792-3949-4-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).