From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHsRF-00075A-17 for qemu-devel@nongnu.org; Wed, 22 Jul 2015 07:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHsRD-0005kT-Uq for qemu-devel@nongnu.org; Wed, 22 Jul 2015 07:43:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHsRD-0005kL-PT for qemu-devel@nongnu.org; Wed, 22 Jul 2015 07:43:51 -0400 From: Stefan Hajnoczi Date: Wed, 22 Jul 2015 12:43:40 +0100 Message-Id: <1437565425-29861-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1437565425-29861-1-git-send-email-stefanha@redhat.com> References: <1437565425-29861-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL v2 for-2.4 v2 2/7] qemu-timer: initialize "timers_done_ev" to set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , Paolo Bonzini From: Paolo Bonzini The normal value for the event is to be set. If we do not do this, pause_all_vcpus (through qemu_clock_enable) hangs unless timerlist_run_timers has been run at least once for the timerlist. This can happen with the following patches, that make aio_notify do nothing most of the time. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Tested-by: Richard W.M. Jones Message-id: 1437487673-23740-2-git-send-email-pbonzini@redhat.com Signed-off-by: Stefan Hajnoczi --- qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c index aa6757e..2463fe6 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -99,7 +99,7 @@ QEMUTimerList *timerlist_new(QEMUClockType type, QEMUClock *clock = qemu_clock_ptr(type); timer_list = g_malloc0(sizeof(QEMUTimerList)); - qemu_event_init(&timer_list->timers_done_ev, false); + qemu_event_init(&timer_list->timers_done_ev, true); timer_list->clock = clock; timer_list->notify_cb = cb; timer_list->notify_opaque = opaque; -- 2.4.3